search

esphome / aioesphomeapi

Python Client for ESPHome native API. Used by Home Assistant.
https://esphome.io/
MIT License
133 stars 65 forks source link

Ensure we are testing on MacOS and Windows #933

Closed bdraco closed 1 month ago

bdraco commented 1 month ago

https://github.com/esphome/aioesphomeapi/pull/932 proposed to use a new socket flag. Its likely this flag does not work on some operating systems that we support, but since we are not testing on them, its non-obvious if it will break or not.

nkinnan commented 1 month ago

It is quite obvious if it will break or not, because I did in fact test, and that's why I had to add the try/catch around the call, because it wasn't supported on one of the platforms I tried. (Referring only to 932)

bdraco commented 1 month ago

It is quite obvious if it will break or not, because I did in fact test, and that's why I had to add the try/catch around the call, because it wasn't supported on one of the platforms I tried. (Referring only to 932)

We need to test MacOS as you mentioned in your comment that you had not tested the change on MacOS https://github.com/esphome/aioesphomeapi/pull/932#issuecomment-2318834197

I added Windows as well as its a oversight in our testing plan that we aren't running the CI on windows.

bdraco commented 1 month ago

Well that was unexpected

tests/test__frame_helper.py::test_noise_frame_helper_bad_encryption PASSED [  6%]
Windows fatal exception: access violation
Current thread 0x00001480 (most recent call first):
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\logging\__init__.py", line 392 in getMessage
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\logging\__init__.py", line 703 in format
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\logging\__init__.py", line 999 in format
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\logging\__init__.py", line 1160 in emit
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\logging\__init__.py", line 1280 in emit
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\logging\__init__.py", line 1028 in handle
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\logging\__init__.py", line 1762 in callHandlers
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\logging\__init__.py", line 1700 in handle
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\logging\__init__.py", line 1684 in _log
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\logging\__init__.py", line 1527 in debug
  File "D:\a\aioesphomeapi\aioesphomeapi\aioesphomeapi\connection.py", line 714 in send_messages
  File "D:\a\aioesphomeapi\aioesphomeapi\aioesphomeapi\connection.py", line 795 in send_messages_await_response_complex
  File "D:\a\aioesphomeapi\aioesphomeapi\aioesphomeapi\connection.py", line 467 in _connect_hello_login
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\asyncio\events.py", line 88 in _run
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\asyncio\base_events.py", line 1986 in _run_once
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\asyncio\base_events.py", line 641 in run_forever
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\asyncio\windows_events.py", line 322 in run_forever
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\asyncio\base_events.py", line 674 in run_until_complete
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\pytest_asyncio\plugin.py", line 929 in inner
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\_pytest\python.py", line 159 in pytest_pyfunc_call
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\pluggy\_callers.py", line 103 in _multicall
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\pluggy\_manager.py", line 120 in _hookexec
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\pluggy\_hooks.py", line [51](https://github.com/esphome/aioesphomeapi/actions/runs/10621862626/job/29444832859?pr=933#step:13:52)3 in __call__
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\_pytest\python.py", line 1627 in runtest
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\pytest_asyncio\plugin.py", line 457 in runtest
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\_pytest\runner.py", line 174 in pytest_runtest_call
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\pluggy\_callers.py", line 103 in _multicall
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\pluggy\_manager.py", line 120 in _hookexec
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\pluggy\_hooks.py", line 513 in __call__
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\_pytest\runner.py", line 242 in <lambda>
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\_pytest\runner.py", line 341 in from_call
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\_pytest\runner.py", line 241 in call_and_report
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\_pytest\runner.py", line 132 in runtestprotocol
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\_pytest\runner.py", line 113 in pytest_runtest_protocol
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\pluggy\_callers.py", line 103 in _multicall
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\pluggy\_manager.py", line 120 in _hookexec
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\pluggy\_hooks.py", line 513 in __call__
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\_pytest\main.py", line 3[62](https://github.com/esphome/aioesphomeapi/actions/runs/10621862626/job/29444832859?pr=933#step:13:63) in pytest_runtestloop
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\pluggy\_callers.py", line 103 in _multicall
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\pluggy\_manager.py", line 120 in _hookexec
  File "C:\hostedtoolcache\windows\Python\3.12.5\x[64](https://github.com/esphome/aioesphomeapi/actions/runs/10621862626/job/29444832859?pr=933#step:13:65)\Lib\site-packages\pluggy\_hooks.py", line 513 in __call__
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\_pytest\main.py", line 337 in _main
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\_pytest\main.py", line 283 in wrap_session
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\_pytest\main.py", line 330 in pytest_cmdline_main
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\pluggy\_callers.py", line 103 in _multicall
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\pluggy\_manager.py", line 120 in _hookexec
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\pluggy\_hooks.py", line 513 in __call__
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\_pytest\config\__init__.py", line 175 in main
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Lib\site-packages\_pytest\config\__init__.py", line 201 in console_main
  File "C:\hostedtoolcache\windows\Python\3.12.5\x64\Scripts\pytest.exe\__main__.py", line 7 in <module>
  File "<frozen runpy>", line 88 in _run_code
  File "<frozen runpy>", line 198 in _run_module_as_main
tests/test__frame_helper.py::test_init_plaintext_with_wrong_preamble
bdraco commented 1 month ago

That looks like a crash in protobuf

nkinnan commented 1 month ago

Never any reason not to add more test coverage.

bdraco commented 1 month ago

Sadly the windows crash isn't reproducible locally so its going to be quite a bit trial and error to figure out how to work around it

coderabbitai[bot] commented 1 month ago

[!WARNING]

Rate limit exceeded

@bdraco has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 49 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between 6cb9d057b3c12e9f4dfac0e7bef5c6c1357aca62 and a0ab8bf57510b1ad51752de11a2de31c9935d301.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.