esphome / bluetooth-proxies

This repo hosts known, tested devices that can serve as Bluetooth proxies for Home Assistant.
https://esphome.io/projects?type=bluetooth
177 stars 62 forks source link

Update gl-s10.yaml #77

Closed Go0oSer closed 1 year ago

Go0oSer commented 1 year ago

Resolves packet loss issue with v2.1 of GL-S10.

trvrnrth commented 1 year ago

Looks to have resolved the connection flakiness with my device 🥳

balloob commented 1 year ago

As stated in our documentation, our website is only supporting revision 2.3.

raoulbhatia commented 1 year ago

@balloob I am curious, Before closing, did you test the current ethernet implementation with hardware rev 2.3 and can confirm that this fix is not required anymore?

It would be good, if you could share more details upon close.

Thanks, Raoul

jesserockz commented 1 year ago

If someone has a v2.3 revision of this board and can verify these changes work, then we will gladly accept it in.

But if the hardware changed and requires clk_mode: GPIO17_OUT then it doesn't make sense to change.

I personally have a v2.1 revision and the change works there.

trvrnrth commented 1 year ago

Accepting the change in the form of a comment regarding the required config for v2.1 (as is already the case for v1.0) would seem like a better solution than just closing the PR if this does not apply to v2.3 devices.

Go0oSer commented 1 year ago

This is my first PR. I did not realize something similar was discussed a few weeks ago. I wanted to make the fix known for those that want them. I would be happy to submit a PR with a comment for v2.1 if that works. I think that is a reasonable solution and makes sure the fix isn't lost.

jesserockz commented 1 year ago

79

raoulbhatia commented 1 year ago

Thanks @jesserockz

balloob commented 1 year ago

If this makes our config compatible with multiple revisions, we should also update the documentation.