esphome / feature-requests

ESPHome Feature Request Tracker
https://esphome.io/
412 stars 26 forks source link

MHZ19B commands to set range not implemented #438

Closed borpin closed 1 year ago

borpin commented 4 years ago

Refers to Issue esphome/issues#709 Operating environment/Installation (Hass.io/Docker/pip/etc.):

Hass.io / Docker ESP (ESP32/ESP8266, Board/Sonoff):

WEMOS D1 Mini Rev 3.1.0 Affected component:

https://esphome.io/components/sensor/mhz19.html

Description of problem: The commands to set the device range, as detailed in the most recent datasheet for this device, have not been implemented. The lack of an ability to set this configuration, may be affecting the values returned by the device.

https://github.com/esphome/esphome/blob/4310c14497be80eb47c33733910242b16aa7aa4a/esphome/components/mhz19/mhz19.cpp#L10-L15

image

image

Problem-relevant YAML-configuration entries:

PASTE YAML FILE HERE

Logs (if applicable):

PASTE DEBUG LOG HERE

Additional information and things you've tried:

OttoWinter commented 4 years ago

The lack of an ability to set this configuration, may be affecting the values returned by the device.

True, but as far as I see the detection range only affects what range of values the device can send. It doesn't make the sensor return "wrong" values.

I will move this to the feature-requests repo because it's a feature request.

close-issue-app[bot] commented 4 years ago

This feature request was auto-closed because the template was not filled out. The ESPHome developers invest lots of time to maintain this project, so please at least fill out the feature request template so that a bunch of standard questions don't need to be asked again each time. Thank you for taking the time to create this feature request.

evils commented 1 year ago

as the 2000-5000ppm range is where mitigation actions are indicated it'd be great if i could get this range out of my sensor...

evils commented 1 year ago

@borpin what completed this?