esphome / issues

Issue Tracker for ESPHome
https://esphome.io/
290 stars 36 forks source link

Improv implementation is not accroding to web spec #2335

Closed dz0ny closed 2 years ago

dz0ny commented 3 years ago

The problem

Improv implementation is not according to web spec, when trying to use https://www.improv-wifi.com/ the error in the console is Firmware not according to spec, missing capability support. Looking at the code it tries to read from it but the service only supports write.

https://github.com/esphome/esphome/blob/dev/esphome/components/esp32_improv/esp32_improv_component.cpp#L33

           try {
                const e = await t.getCharacteristic("00467768-6228-2272-4663-277478268003")
                  , i = await e.readValue();
                this._improvCapabilities = i.getUint8(0)
            } catch (t) {
                console.warn("Firmware not according to spec, missing capability support.")
            }

Which version of ESPHome has the issue?

dev

What type of installation are you using?

pip

Which version of Home Assistant has the issue?

none

What platform are you using?

ESP32

Board

esp32-devkitc

Component causing the issue

improv

Example YAML snippet

wifi:

improv:

Anything in the logs that might be useful for us?

No response

Additional information

When using https://googlechrome.github.io/samples/web-bluetooth/characteristic-properties.html?service=00467768-6228-2272-4663-277478268000&characteristic=00467768-6228-2272-4663-277478268003

I can see that service has only write enabled

Requesting Bluetooth Device... Connecting to GATT Server... Getting Service... Getting Characteristic...

Characteristic UUID: 00467768-6228-2272-4663-277478268003 Broadcast: false Read: false Write w/o response: false Write: true Notify: false Indicate: false Signed Write: false Queued Write: false Writable Auxiliaries: false

probot-esphome[bot] commented 3 years ago

Hey there @jesserockz, mind taking a look at this issue as it has been labeled with an integration (improv) you are listed as a code owner for? Thanks! (message by CodeOwnersMention)

probot-esphome[bot] commented 3 years ago

Hey there @jesserockz, mind taking a look at this issue as it has been labeled with an integration (esp32_improv) you are listed as a code owner for? Thanks! (message by CodeOwnersMention)

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.