esphome / issues

Issue Tracker for ESPHome
https://esphome.io/
290 stars 36 forks source link

Possible esphome-docs reference mistake #4052

Open hansonap opened 1 year ago

hansonap commented 1 year ago

The problem

While looking at the documentation for the component filter exponential_moving_average I noticed that the link for "exponential moving average" took you to a NIST's quantile Dataplot page. While I am not familiar with Dataplot or Simple Moving Quantile filter, the method in the NIST link and the implementation of ESPHome's Simple Moving Average have a striking similarity.

However, ESPHome's Quantile implementation has does not resemble NIST's page. I'm sure this is a lack of understanding but wanted to make sure there wasn't an opportunity to correct the reference or make the explanation in the docs / code more clear.

@glmnet, @sisco0

Which version of ESPHome has the issue?

2022.12.4 esphome-docs

What type of installation are you using?

Not using Home Assistant

Which version of Home Assistant has the issue?

Not using Home Assistant

What platform are you using?

ESP32

Board

esp32-c3-devkitm-1

Component causing the issue

Component

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

esphome-docs

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.