PZEM-004T, Improve ESP_LOGD with Device ID

The problem

Hi;

Lately, a lot of projects are coming up using 2 or more pzem..

It's my case, I'm using 9 pzem with 1 Nodemcu...

Now it's working correctly, but, during programming, the debugging part was a little tricky..

As I have more than 1, during the debug, the log returns more device information, but without the address, so I don't know which one was actually sending the response...

Captura de Tela 2023-01-29 às 16 35 51

Analyzing the code, I came to this line (49 / 50): File: pzemac.cpp

   ESP_LOGD(TAG, "PZEM AC: V=%.1f V, I=%.3f A, P=%.1f W, E=%.1f Wh, F=%.1f Hz, PF=%.2f", voltage, current, active_power,
            active_energy, frequency, power_factor);

This is where I have been declaring the pzem, with its settings

  - {platform: pzemac, address: 2, modbus_id: modbus_pzemG1, id: pzem12, current: {name: "pzem12-corrente"}, voltage: {name: "pzem12-tensao"}, energy: {name: "pzem12-energy"}, power: {name: "pzem12-power"}, frequency: {name: "pzem12-frequencia"}, power_factor: {name: "pzem12-fator_potencia"}, update_interval: never}
  - {platform: pzemac, address: 3, modbus_id: modbus_pzemG1, id: pzem13, current: {name: "pzem13-corrente"}, voltage: {name: "pzem13-tensao"}, energy: {name: "pzem13-energy"}, power: {name: "pzem13-power"}, frequency: {name: "pzem13-frequencia"}, power_factor: {name: "pzem13-fator_potencia"}, update_interval: never}
  # - {platform: pzemac, address: 4, modbus_id: modbus_pzemG1, id: pzem14, current: {name: "pzem14-corrente"}, voltage: {name: "pzem14-tensao"}, energy: {name: "pzem14-energy"}, power: {name: "pzem14-power"}, frequency: {name: "pzem14-frequencia"}, power_factor: {name: "pzem14-fator_potencia"}, update_interval: never}
  - {platform: pzemac, address: 5, modbus_id: modbus_pzemG1, id: pzem15, current: {name: "pzem15-corrente"}, voltage: {name: "pzem15-tensao"}, energy: {name: "pzem15-energy"}, power: {name: "pzem15-power"}, frequency: {name: "pzem15-frequencia"}, power_factor: {name: "pzem15-fator_potencia"}, update_interval: never}
  - {platform: pzemac, address: 6, modbus_id: modbus_pzemG1, id: pzem16, current: {name: "pzem16-corrente"}, voltage: {name: "pzem16-tensao"}, energy: {name: "pzem16-energy"}, power: {name: "pzem16-power"}, frequency: {name: "pzem16-frequencia"}, power_factor: {name: "pzem16-fator_potencia"}, update_interval: never}
  - {platform: pzemac, address: 2, modbus_id: modbus_pzemG2, id: pzem22, current: {name: "pzem22-corrente"}, voltage: {name: "pzem22-tensao"}, energy: {name: "pzem22-energy"}, power: {name: "pzem22-power"}, frequency: {name: "pzem22-frequencia"}, power_factor: {name: "pzem22-fator_potencia"}, update_interval: never}
  - {platform: pzemac, address: 3, modbus_id: modbus_pzemG2, id: pzem23, current: {name: "pzem23-corrente"}, voltage: {name: "pzem23-tensao"}, energy: {name: "pzem23-energy"}, power: {name: "pzem23-power"}, frequency: {name: "pzem23-frequencia"}, power_factor: {name: "pzem23-fator_potencia"}, update_interval: never}
  - {platform: pzemac, address: 4, modbus_id: modbus_pzemG2, id: pzem24, current: {name: "pzem24-corrente"}, voltage: {name: "pzem24-tensao"}, energy: {name: "pzem24-energy"}, power: {name: "pzem24-power"}, frequency: {name: "pzem24-frequencia"}, power_factor: {name: "pzem24-fator_potencia"}, update_interval: never}
  - {platform: pzemac, address: 5, modbus_id: modbus_pzemG2, id: pzem25, current: {name: "pzem25-corrente"}, voltage: {name: "pzem25-tensao"}, energy: {name: "pzem25-energy"}, power: {name: "pzem25-power"}, frequency: {name: "pzem25-frequencia"}, power_factor: {name: "pzem25-fator_potencia"}, update_interval: never}
  - {platform: pzemac, address: 6, modbus_id: modbus_pzemG2, id: pzem26, current: {name: "pzem26-corrente"}, voltage: {name: "pzem26-tensao"}, energy: {name: "pzem26-energy"}, power: {name: "pzem26-power"}, frequency: {name: "pzem26-frequencia"}, power_factor: {name: "pzem26-fator_potencia"}, update_interval: never}

my suggestion is to add the id, making it easier to know which device is getting a response!

Which version of ESPHome has the issue?

v2022.12.8

What type of installation are you using?

Docker

Which version of Home Assistant has the issue?

No response

What platform are you using?

ESP8266

Board

Nodemcu

Component causing the issue

pzemac

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

esphome / issues