daly_bms incorrect device_class for CONF_REMAINING_CAPACITY

codewise-nicolas commented 1 year ago

The problem

HA is reporting an error related to the device class for remaining capacity in the daly_bms component because it is set to a device_class of voltage, but the units is Ah. I dont think HA as a unit of measurement of "Ah" and therefore may not have a device_class related to that.

Maybe device_class should change to DEVICE_CLASS_CURRENT ?

Component entity: https://github.com/esphome/esphome/blob/ac5246e21dbf4d119b380f1621bf418b0523a631/esphome/components/daly_bms/sensor.py#L174

HA Constants https://github.com/home-assistant/core/blob/dev/homeassistant/const.py

Which version of ESPHome has the issue?

2023.6.2

What type of installation are you using?

Home Assistant Add-on

Which version of Home Assistant has the issue?

2023.6.3

What platform are you using?

ESP8266

Board

No response

Component causing the issue

daly_bms

Example YAML snippet

No response

Anything in the logs that might be useful for us?

remaining_capacity (<class 'homeassistant.components.mqtt.sensor.MqttSensor'>) is using native unit of measurement 'Ah' which is not a valid unit for the device class ('voltage')

Additional information

No response

github-actions[bot] commented 10 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

codewise-nicolas commented 10 months ago

I guess no update on this eh?

esphome / issues