DSMR module (dev) not showing correct values for 13 month average peek

[VerstrooidProfke]

The problem

While merging the (dev) version of DSMR; I see a small bug in the calculation of "active_energy_import_maximum_demand_last_13_months" It does not show the 13_months_average peak, but te month peak of the month before...

I checked this via validation on "my fluvius", in May, the number "13-month-average-peak" showed

I'm not sure if the code is wrong, or the smartmeter delivers wrong numbers, but the number that is parsed, currently is "last monthts peak, and not "last years average peak".

Some screenshots to show

"active_energy_import_maximum_demand_last_13_months" shows 4,627 in june, while it should show 4,1314

"active_energy_import_maximum_demand_last_13_months" shows 4,043 in july, while it should show 4,11667 Also, you can see the "current month" has a higher peak then the "current year"? this seems wrong.

Which version of ESPHome has the issue?

2023.7.0

What type of installation are you using?

Docker

Which version of Home Assistant has the issue?

All versions, i suppose. running 2023,7,2 right now

What platform are you using?

ESP8266

Board

No response

Component causing the issue

No response

Example YAML snippet

ESPHOME:

#https://www.esphome.io/components/external_components.html?highlight=external
external_components:
   - source:
      type: git
      url: https://github.com/bwynants/esphome
      ref: capacity_test
    components: [ dsmr ]

sensor:
  - platform: dsmr
    energy_delivered_tariff1:
      name: "Electriciteit DAG"
    energy_delivered_tariff2:
      name: "Electriciteit NACHT"
    #energy_returned_tariff1:
    #  name: "Teruggeleverde energie Tarief 1"
    #energy_returned_tariff2:
    #  name: "Teruggeleverde energie Tarief 2"
    power_delivered:
      name: "Verbruikt Vermogen"
    #power_returned:
    #  name: "Geleverd Vermogen"
    voltage_l1:
      name: "Spanning Fase 1"
    voltage_l2:
      name: "Spanning Fase 2"
    voltage_l3:
      name: "Spanning Fase 3"
    current_l1:
      name: "Stroom Fase 1"
    current_l2:
      name: "Stroom Fase 2"
    current_l3:
      name: "Stroom Fase 3"
    gas_delivered_be:
      name: "Verbruik Gas"
    active_energy_import_maximum_demand_running_month:
      name: "piekgebruik huidige maand"
    active_energy_import_current_average_demand:
      name: "Huidig kwartierverbruik"
    active_energy_import_maximum_demand_last_13_months:
      name: "13 maand piek kwartierverbruik"

HA dashboard config:
type: vertical-stack
cards:
  - show_name: true
    show_icon: false
    show_state: true
    type: glance
    entities:
      - entity: sensor.huidig_kwartierverbruik
        name: Huidig Kwartier
      - entity: sensor.piekgebruik_huidige_maand
        name: Maand
      - entity: sensor.13_maand_piek_kwartierverbruik
        name: Jaar
    title: Piekgebruik
  - type: history-graph
    hours_to_show: 12
    entities:
      - entity: sensor.huidig_kwartierverbruik
        name: Huidig Kwartier
      - entity: sensor.piekgebruik_huidige_maand
        name: Huidige maandpiek
      - entity: sensor.13_maand_piek_kwartierverbruik
        name: Huidige jaarpiek
    show_names: false

Anything in the logs that might be useful for us?

No response

Additional information

No response

[mhaket]

Example raw telegram from a BE meter:

/FLU5\253769484_A

0-0:96.1.4(50217)
0-0:96.1.1(3153414733313030303633383033)
0-0:1.0.0(231115094532W)
1-0:1.8.1(006780.240*kWh)
1-0:1.8.2(011645.231*kWh)
1-0:2.8.1(023545.888*kWh)
1-0:2.8.2(009317.351*kWh)
0-0:96.14.0(0001)
1-0:1.4.0(00.002*kW)
1-0:1.6.0(231105170000W)(02.391*kW)
0-0:98.1.0(11)(1-0:1.6.0)(1-0:1.6.0)(230101000000W)(221206183000W)(06.134*kW)(230201000000W)(230127174500W)(05.644*kW)(230301000000W)(230226063000W)(04.895*kW)(230401000000S)(230305181500W)(04.879*kW)(230501000000S)(230416094500S)(04.395*kW)(230601000000S)(230522084500S)(03.242*kW)(230701000000S)(230623053000S)(01.475*kW)(230801000000S)(230724060000S)(02.525*kW)(230901000000S)(230819174500S)(02.491*kW)(231001000000S)(230911063000S)(02.342*kW)(231101000000W)(231031234500W)(02.048*kW)
1-0:1.7.0(00.133*kW)
1-0:2.7.0(00.000*kW)
1-0:21.7.0(00.657*kW)
1-0:41.7.0(00.000*kW)
1-0:61.7.0(00.000*kW)
1-0:22.7.0(00.000*kW)
1-0:42.7.0(00.293*kW)
1-0:62.7.0(00.230*kW)
1-0:32.7.0(234.9*V)
1-0:52.7.0(239.2*V)
1-0:72.7.0(240.0*V)
1-0:31.7.0(003.37*A)
1-0:51.7.0(001.65*A)
1-0:71.7.0(001.26*A)
0-0:96.3.10(1)
0-0:17.0.0(999.9*kW)
1-0:31.4.0(999*A)
0-0:96.13.0()
0-1:24.1.0(003)
0-1:96.1.1(37464C4F32313139313233303733)
0-1:24.4.0(1)
0-1:24.2.3(231115094007W)(11722.671*m3)
!ab1b

This is the value for 'active_energy_import_maximum_demand_last_13_months':

0-0:98.1.0(11)(1-0:1.6.0)(1-0:1.6.0)(230101000000W)(221206183000W)(06.134*kW)(230201000000W)(230127174500W)(05.644*kW)(230301000000W)(230226063000W)(04.895*kW)(230401000000S)(230305181500W)(04.879*kW)(230501000000S)(230416094500S)(04.395*kW)(230601000000S)(230522084500S)(03.242*kW)(230701000000S)(230623053000S)(01.475*kW)(230801000000S)(230724060000S)(02.525*kW)(230901000000S)(230819174500S)(02.491*kW)(231001000000S)(230911063000S)(02.342*kW)(231101000000W)(231031234500W)(02.048*kW)

With the current implementation of DSRM the value 2.048 kW is returned in stead of the complete array of values.

[bwynants]

https://github.com/glmnet/arduino-dsmr/pull/18

[bwynants]

add

external_components:
  - source:
      type: git
      url: https://github.com/bwynants/esphome
      ref: dsmr
    components: [dsmr]
    refresh: 0s

to your yaml for this fix until esphome is updated

[mhaket]

While compiling it for a esp32-c3-devkitm-1 board, I get the following error:

INFO ESPHome 2023.12.9
INFO Reading configuration /config/esphome/device.yaml...
INFO Updating https://github.com/bwynants/esphome@dsmr
INFO Generating C++ source...
INFO Compiling app...
Processing device (board: esp32-c3-devkitm-1; framework: arduino; platform: platformio/espressif32@5.4.0)
--------------------------------------------------------------------------------
HARDWARE: ESP32C3 160MHz, 320KB RAM, 4MB Flash
 - toolchain-riscv32-esp @ 8.4.0+2021r2-patch5
Dependency Graph
|-- AsyncTCP-esphome @ 2.0.1
|-- WiFi @ 2.0.0
|-- FS @ 2.0.0
|-- Update @ 2.0.0
|-- ESPAsyncWebServer-esphome @ 3.1.0
|-- DNSServer @ 2.0.0
|-- ESPmDNS @ 2.0.0
|-- ArduinoJson @ 6.18.5
|-- Improv @ 1.2.3
|-- Dsmr @ 0.9.0+sha.48b1dad
|-- Crypto @ 0.4.0
|-- noise-c @ 0.1.4
Compiling .pioenvs/device/src/esphome/components/dsmr/dsmr.cpp.o
Compiling .pioenvs/device/src/esphome/components/esp32/gpio.cpp.o
Compiling .pioenvsdevice/src/esphome/components/esp32/preferences.cpp.o
In file included from src/esphome/components/dsmr/dsmr.h:14,
                 from src/esphome/components/dsmr/dsmr.cpp:3:
.piolibdeps/device/arduino-dsmr/src/dsmr/fields.h: In member function 'dsmr::ParseResult<void> dsmr::AveragedFixedField<T, _unit, _int_unit>::parse(const char*, const char*)':
.piolibdeps/device/arduino-dsmr/src/dsmr/fields.h:188:16: error: 'uint32' was not declared in this scope
           for (uint32 i = 0; i < numberOfValues.result; i++)
                ^~~~~~
.piolibdeps/device/arduino-dsmr/src/dsmr/fields.h:188:16: note: suggested alternative: 'uint'
           for (uint32 i = 0; i < numberOfValues.result; i++)
                ^~~~~~
                uint
.piolibdeps/device/arduino-dsmr/src/dsmr/fields.h:188:30: error: 'i' was not declared in this scope
           for (uint32 i = 0; i < numberOfValues.result; i++)
                              ^
*** [.pioenvs/device/src/esphome/components/dsmr/dsmr.cpp.o] Error 1
========================== [FAILED] Took 2.78 seconds ==========================

Full YAML file:

substitutions:
  device_name: <hidden>

esphome:
  name: ${device_name}
  name_add_mac_suffix: false
  platformio_options:
    upload_speed: 1500000

esp32:
  board: esp32-c3-devkitm-1

improv_serial:
  next_url: http://{{ip_address}}

status_led:
  pin:
    number: 7
    inverted: true
    id: led

# temporary fix https://github.com/esphome/issues/issues/4750#issuecomment-1906850672
external_components:
  - source:
      type: git
      url: https://github.com/bwynants/esphome
      ref: dsmr
    components: [dsmr]
    refresh: 0s
#end fix

api:
  services:
    - service: reboot
      then:
        - button.press:
            id: reboot

ota:

wifi:
  ssid: !secret wifi_ssid
  password: !secret wifi_password  
  power_save_mode: none
# Enable fallback hotspot (captive portal) in case wifi connection fails
  ap:
    ssid: ${device_name}
    ap_timeout: 15s

captive_portal:

web_server:
  port: 80

# Enable logging
logger:
  level: INFO

#esp32_ble_tracker:
#  scan_parameters:
#    interval: 1100ms
#    window: 1100ms
#    active: true

#bluetooth_proxy:
#  active: true

uart:
  rx_pin:
    number: 10
    inverted: true
  baud_rate: 115200
#  rx_buffer_size: 1700

dsmr:
  water_mbus_id: 2
# id: dsmr_instance
# receive_timeout: 200ms
# max_telegram_length: 1700

button:  
  - platform: restart
    name: "_Restart device"
    id: reboot
  - platform: factory_reset
    name: "_Restart with Factory Default Settings"

sensor:
  - platform: dsmr
#    energy_delivered_lux:
#      name: "Energy Consumed Luxembourg"
#      state_class: total_increasing
    energy_delivered_tariff1:
      name: "Energy Consumed Tariff 1"
      state_class: total_increasing
      device_class: energy
    energy_delivered_tariff2:
      name: "Energy Consumed Tariff 2"
      state_class: total_increasing
      device_class: energy
#    energy_returned_lux:
#      name: "Energy Produced Luxembourg"
#      state_class: total_increasing
    energy_returned_tariff1:
      name: "Energy Produced Tariff 1"
      state_class: total_increasing
    energy_returned_tariff2:
      name: "Energy Produced Tariff 2"
      state_class: total_increasing
    power_delivered:
      name: "Power Consumed"
      unit_of_measurement: "W"
      state_class: "measurement"
      accuracy_decimals: 0
      filters:
        - multiply: 1000
    power_returned:
      name: "Power Produced"
      unit_of_measurement: "W"
      state_class: "measurement"
      accuracy_decimals: 0
      filters:
        - multiply: 1000
    electricity_failures:
      name: "Electricity Failures"
      icon: mdi:alert
    electricity_long_failures:
      name: "Long Electricity Failures"
      icon: mdi:alert
    voltage_l1:
      name: "Voltage Phase 1"
    voltage_l2:
      name: "Voltage Phase 2"
    voltage_l3:
      name: "Voltage Phase 3"
    current_l1:
      name: "Current Phase 1"
    current_l2:
      name: "Current Phase 2"
    current_l3:
      name: "Current Phase 3"
    power_delivered_l1:
      name: "Power Consumed Phase 1"
      unit_of_measurement: "W"
      state_class: "measurement"
      accuracy_decimals: 0
      filters:
        - multiply: 1000
    power_delivered_l2:
      name: "Power Consumed Phase 2"
      unit_of_measurement: "W"
      state_class: "measurement"
      accuracy_decimals: 0
      filters:
        - multiply: 1000
    power_delivered_l3:
      name: "Power Consumed Phase 3"
      unit_of_measurement: "W"
      state_class: "measurement"
      accuracy_decimals: 0
      filters:
        - multiply: 1000
    power_returned_l1:
      name: "Power Produced Phase 1"
      unit_of_measurement: "W"
      state_class: "measurement"
      accuracy_decimals: 0
      filters:
        - multiply: 1000
    power_returned_l2:
      name: "Power Produced Phase 2"
      unit_of_measurement: "W"
      state_class: "measurement"
      accuracy_decimals: 0
      filters:
        - multiply: 1000
    power_returned_l3:
      name: "Power Produced Phase 3"
      unit_of_measurement: "W"
      state_class: "measurement"
      accuracy_decimals: 0
      filters:
        - multiply: 1000
    gas_delivered:
      name: "Gas Consumed"
      state_class: total_increasing
    gas_delivered_be:
      name: "Gas Consumed Belgium"
      state_class: total_increasing
    active_energy_import_current_average_demand:
      name: "Current Average Demand"
      unit_of_measurement: "W"
      state_class: measurement
      accuracy_decimals: 0
      filters:
        - multiply: 1000
    active_energy_import_maximum_demand_running_month:
      name: "Maximum Month Demand"
      unit_of_measurement: "W"
      state_class: measurement
      accuracy_decimals: 0
      filters:
        - multiply: 1000
    active_energy_import_maximum_demand_last_13_months:
      name: "13 Month Maximum Quarterly Demand"    
  - platform: uptime
    name: "Uptime"
  - platform: wifi_signal
    name: "Wi-Fi Signal"
    update_interval: 60s

text_sensor:
  - platform: dsmr
    identification:
      name: "DSMR Identification"
    p1_version:
      name: "DSMR Version"
    p1_version_be:
      name: "DSMR Version Belgium"
  - platform: wifi_info
    ip_address:
      name: "IP Address"
    ssid:
      name: "Wi-Fi SSID"
    bssid:
      name: "Wi-Fi BSSID"
  - platform: version
    name: "ESPHome Version"
    hide_timestamp: true

I cleared the cache and retried but same result.

[bwynants]

In file included from src/esphome/components/dsmr/dsmr.h:14, from src/esphome/components/dsmr/dsmr.cpp:3: .piolibdeps/device/arduino-dsmr/src/dsmr/fields.h: In member function 'dsmr::ParseResult dsmr::AveragedFixedField<T, _unit, _int_unit>::parse(const char, const char)': .piolibdeps/device/arduino-dsmr/src/dsmr/fields.h:188:16: error: 'uint32' was not declared in this scope for (uint32 i = 0; i < numberOfValues.result; i++) ^~ .piolibdeps/device/arduino-dsmr/src/dsmr/fields.h:188:16: note: suggested alternative: 'uint' for (uint32 i = 0; i < numberOfValues.result; i++) ^~ uint .piolibdeps/device/arduino-dsmr/src/dsmr/fields.h:188:30: error: 'i' was not declared in this scope for (uint32 i = 0; i < numberOfValues.result; i++) ^ *** [.pioenvs/device/src/esphome/components/dsmr/dsmr.cpp.o] Error 1

fixed, try again

[mhaket]

Compiled and works.

Question, what value is now returned? I expected an array of 13 values but I receive only one.

[bwynants]

Compiled and works.

Question, what value is now returned? I expected an array of 13 values but I receive only one.

the single value as reported under https://mijn.fluvius.be/netkosten/ this is the average value (gemiddelde) of those 13 (or possibly less) values

[mhaket]

Clear. Thanks for the library update.