esphome / issues

Issue Tracker for ESPHome
https://esphome.io/
290 stars 34 forks source link

Substitutions Don't Work in Package Definition #4939

Open barndawgie opened 11 months ago

barndawgie commented 11 months ago

The problem

I created the following configuration:

---
substitutions:
  github_ref: main

packages:
  econet:
    url: https://github.com/esphome-econet/esphome-econet
    ref: ${github_ref}
    file: econet_heatpump_water_heater.yaml

I expected this to work, but instead get the error:

Not a valid git ref.
    ref: ${github_ref}

If I replace ${github_ref} with main it works.

Which version of ESPHome has the issue?

2023.9.1

What type of installation are you using?

pip

Which version of Home Assistant has the issue?

No response

What platform are you using?

ESP32

Board

m5Stack ATOM Lite

Component causing the issue

No response

Example YAML snippet

---
substitutions:
  github_ref: main

packages:
  econet:
    url: https://github.com/esphome-econet/esphome-econet
    ref: ${github_ref}
    file: econet_heatpump_water_heater.yaml

Anything in the logs that might be useful for us?

Failed config

packages: [source example-esp32.yaml:10]
  econet:
    url: https://github.com/esphome-econet/esphome-econet

    Not a valid git ref.
    ref: ${github_ref}
    file: econet_heatpump_water_heater.yaml


### Additional information

_No response_
github-actions[bot] commented 7 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

barndawgie commented 7 months ago

Would love to see this fixed!