search

esphome / issues

Issue Tracker for ESPHome
https://esphome.io/
290 stars 34 forks source link

Dashboard window resize closes yaml editor without saving #4987

Open samuelolteanu opened 10 months ago

samuelolteanu commented 10 months ago

The problem

Like the title sais, when editing ESPHome yaml on Windows Chrome, I need to be extra careful to not modify window size or press F12 key (close to backspace on my keyboard) when editing or flashing because it will revert to device list without saving any work. This happens of Firefox too but accidentally pressing F12 does not modify window size when using this browser.

https://github.com/esphome/issues/assets/85267083/4f4e4747-534a-422c-ade6-0819f2c2a282

Which version of ESPHome has the issue?

2023.9.3

What type of installation are you using?

Home Assistant Add-on

Which version of Home Assistant has the issue?

2023.10.3

What platform are you using?

ESP8266

Board

No response

Component causing the issue

Dashboard

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

Separate issue maybe? Can't edit esphome yaml on android with the dashboard. Cannot select text and syntax error detail popups don't show wich is not ideal because I could get a board with me and connect it via wireguard component but i need a bulky laptop as well.

https://github.com/esphome/issues/assets/85267083/44ff71dd-d7c1-4e71-b851-22c62b9f60f9

randybb commented 10 months ago

Cannot reproduce that on latest chrome and firefox - it never gets reloaded.

The second "issue" is a known one - limitation of the Monaco editor.

jesserockz commented 10 months ago

I just tried this myself on Chrome and I could not reproduce it at all. No matter how much I changed the size, it stayed in the editor the whole time

samuelolteanu commented 10 months ago

On [Microsoft] remote desktop (from Android), it's system resolution dependant: not happening at 720p, present at more than 1080p, any scale. Tried on 2 different remote windows computers (win10 and server 2022) on 2 different HA installs new + old. Latest Chrome, Firefox, Edge. Tried sfc scannow, created different windows user. Always present on physical access, no matter the resolution and dpi, even after reboot. Update: present on win11 as well, changed system and browser language to english, same behavior. NOT present in docker (casaos) or manual install, so it' looks to be specific to Home Assistant addon.

samuelolteanu commented 9 months ago

20231116_172234 Quick workaround....

patienttruth commented 3 months ago

I just had this happen when compiling a config to update with. Not sure if it would be a problem, but glad it didn't happen when the actual OTA update was happening.