esphome / issues

Issue Tracker for ESPHome
https://esphome.io/
290 stars 34 forks source link

ValueError when uploading via network and not having defined api #8

Closed exxamalte closed 5 years ago

exxamalte commented 5 years ago

Operating environment (Hass.io/Docker/pip/etc.):

ESP (ESP32/ESP8266/Board/Sonoff):

Affected component:

OTA upload

Description of problem: When uploading new firmware over the air, from the command line and using the --upload-port with an IP address, and not having api defined in the configuration, a ValueError appears on the console after successfully uploading the firmware.

Problem-relevant YAML-configuration entries:

n/a

Key api is not defined.

Traceback (if applicable):

Uploading: [============================================================] 100% Done...

INFO Waiting for result...
INFO Result: OK
INFO Successfully uploaded program.
Traceback (most recent call last):
  File "/Users/malte/Programming/esphome/bin/esphomeyaml", line 11, in <module>
    sys.exit(main())
  File "/Users/malte/Programming/esphome/lib/python2.7/site-packages/esphomeyaml/__main__.py", line 505, in main
    return run_esphomeyaml(sys.argv)
  File "/Users/malte/Programming/esphome/lib/python2.7/site-packages/esphomeyaml/__main__.py", line 495, in run_esphomeyaml
    return POST_CONFIG_ACTIONS[args.command](args, config)
  File "/Users/malte/Programming/esphome/lib/python2.7/site-packages/esphomeyaml/__main__.py", line 318, in command_run
    return show_logs(config, args, port)
  File "/Users/malte/Programming/esphome/lib/python2.7/site-packages/esphomeyaml/__main__.py", line 224, in show_logs
    raise ValueError
ValueError

Additional information: This is caused by https://github.com/OttoWinter/esphomeyaml/pull/332 which attempted to fix the issue, but does not cover the case where the firmware is uploaded OTA without having defined the api integration yet.

OttoWinter commented 5 years ago

Closing due to inactivity