Closed Fusseldieb closed 5 years ago
For frequency you're right, that should be Hz by default.
For power factor, I don't agree so much. Technically, power factor does not have a unit (it's a ratio), the only valid unit would be 1
mathematically speaking.
Wow! Thanks so much for this fast PR! You're awesome @OttoWinter :)
Well, about the Power Factor. "1" as a unit would confuse/annoy people, for sure. But PF is just the name itself. It just needs to be something for the graph to show up.
EDIT: Autocorrect bad
Operating environment/Installation (Hass.io/Docker/pip/etc.):
Not relevant
ESP (ESP32/ESP8266, Board/Sonoff):
Not relevant
Affected component:
https://esphome.io/components/sensor/pzem004t.html
Description of problem: I don't know if I should ask this as a bug or feature request, but basically it would be nice to report PZEMs frequency as "Hz" instead of nothing. The thing is, when Home Assistant has a unit_of_measurement is displays useful graphs, but when it has none, it makes a lot of slices, rendering histories with a lot of changes useless, which is this case.
Not only that, but the browser lags massively trying to make this "slice-graph", instead of the normal line-graph. It takes 40+ seconds for it to load, while others with the same amount of info take less than 8 sec.
The browser didn't respond anymore. Even when it did finally load, hovering over the card made it go unresponsive again.
All this can be solved using
unit_of_measurement
s. I would really appreciate it.I would suggest Hz for frequency and PF for power factor.
Problem-relevant YAML-configuration entries:
Logs (if applicable):
Additional information and things you've tried: Theoretically I could make a template sensor inside HA, but I think this should be done inside the conponent itself.