search

espi0n / Dockerfiles

38 stars 3 forks source link

Why checkout to a specific version in Datasploit ? #1

Open Chan9390 opened 6 years ago

Chan9390 commented 6 years ago

This question was raised by @anantshri

Why did I checkout to specific version of Datasploit ?

As some modules of this tool depends on API keys provided by the user, there will be an error if the latest version of Datasploit [in the future] doesnt find an API key in the committed version of config.py file.

To temporarily avoid that, I have checked out to a specific version to make sure that the Dockerfile could be used at any time. Once a new update is available with additional API key spaces, I will manually updated the config.py file and checkout to the latest version at that particular time.

I think it is better to keep this issue open until the framework itself changes / updates its error handling mechanisms.

Chan9390 commented 6 years ago

I was also informed that @anantshri has already raised an issue about the error handling mechanism. (https://github.com/DataSploit/datasploit/issues/176)

This issue cannot be closed until the upstream issue is resolved.