Closed D-Keqi closed 2 years ago
Please fix https://github.com/espnet/espnet_model_zoo/runs/4211725385?check_suite_focus=true#step:8:66
Sure! But I still do not know why I got a CI issue. I just append a line to the table.csv and I have tested the CI locally, in which no issue was reported.
Please fix https://github.com/espnet/espnet_model_zoo/runs/4211725385?check_suite_focus=true#step:8:66
Sure! But I still do not know why I got a CI issue. I just append a line to the table.csv and I have tested the CI locally, in which no issue was reported.
The error message says that the model you added does not follow the correct format probably due to that the model was uploaded at huggingface hub. @Fhrozen, can you help us to fix it? The test does not seem to consider the model in huggingface hub.
Please fix https://github.com/espnet/espnet_model_zoo/runs/4211725385?check_suite_focus=true#step:8:66
Sure! But I still do not know why I got a CI issue. I just append a line to the table.csv and I have tested the CI locally, in which no issue was reported.
The error message says that the model you added does not follow the correct format probably due to that the model was uploaded at huggingface hub. @Fhrozen, can you help us to fix it? The test does not seem to consider the model in huggingface hub.
I see. I used to upload the model via zenodo, but It seems that there are some issues with zenodo. So I chose the huggingface as encouraged by the documents.
The problem is with the use of the class for pretrained models on espnet (i.e. Speech2Text). Until now the downloader works well and for our experiments we did not use that description for test. https://github.com/espnet/espnet/blob/master/espnet2/main_funcs/pack_funcs.py#L18-L36
It will be required to add that in case of a directory (such as the one downloaded from huggingface) skip any extraction: https://github.com/espnet/espnet/blob/713e784c0815ebba2053131307db5f00af5159ea/espnet2/main_funcs/pack_funcs.py#L55-L61
@Fhrozen, can you fix this? Can we change the test for the HF hub case?
sure, I will submit a PR for this issue.
It still has an issue https://github.com/espnet/espnet_model_zoo/runs/4394917703?check_suite_focus=true#step:8:95
I have fixed it again. Sorry, can you approve it again for a test? @Fhrozen
I found the issue. I need to change the tag of the streaming Transformer model uploaded by Emiru to fix the CI issue.
Thanks, @D-Keqi and @Fhrozen!
Codecov Report
Continue to review full report at Codecov.