espocrm / espocrm-installer

EspoCRM installation script
Apache License 2.0
9 stars 4 forks source link

Install.sh fails on Linux Mint 21.3 #7

Closed mhmoran closed 9 months ago

mhmoran commented 9 months ago

Describe the bug Fresh install on Linux Mint 21.3, sudo bash install.sh fails with cat: /etc/upstream-release: Is a directory

To Reproduce (MANDATORY, DO NOT REMOVE) Explicit steps to reproduce the behavior:

  1. Fresh install of Linux Mint 21.3
  2. wget https://github.com/espocrm/espocrm-installer/releases/latest/download/install.sh
  3. sudo bash install.sh

Expected behavior The install script to recognize that it is running on a Linux Mint 21.3 system and appropriately determine the information it needs from the /etc/upstream-release directory

Screenshots If applicable, add screenshots to help explain your problem.

EspoCRM version Specify the EspoCRM version (or versions) on which the bug occurs. Fresh pull of Espo 8.1.4 Espo_ss

Additional context Add any other context about the problem here.

yurikuzn commented 9 months ago

The Mint OS is not supported. Not a bug. It was added to the docs by a mistake.

mhmoran commented 9 months ago

Except that the documentation explicitly states that "Linux Mint" is a supported OS.

The problem is  that this piece of code:

 local linuxString=$(cat /etc/*release | grep ^NAME | tr -d 'NAME="' | tr '[:upper:]' '[:lower:]')

 declare -a linuxOsList=(centos redhat fedora ubuntu debian mint)

To me, it says that Linux Mint is is a supported OS ...

NAME="Linux Mint"   -- which is the right string

The  tr -d 'Name="'  returns the string  -- Linux int -- Which is too long and int doesn't match any of the names in the linuxOsList

Mike

On 2/14/24 10:16, Yuri Kuznetsov wrote:

As the Error states, OS is not supported. Not a bug.

— Reply to this email directly, view it on GitHub https://github.com/espocrm/espocrm-installer/issues/7#issuecomment-1944157234, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACOD7J2XLNMJWII7YF4MQETYTTPNFAVCNFSM6AAAAABDHFZAOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBUGE2TOMRTGQ. You are receiving this because you authored the thread.Message ID: @.***>

tmachyshyn commented 9 months ago

@mhmoran after deep investigating we added support Linux Mint. So, please use the documentation for the installation, https://docs.espocrm.com/administration/installation-by-script/ .