search

espocrm / espocrm

EspoCRM – Open Source CRM Application
https://www.espocrm.com
GNU Affero General Public License v3.0
1.77k stars 576 forks source link

class 'app-portal' disappeared from <body> #3143

Closed hdijkema closed 1 month ago

hdijkema commented 1 month ago

Describe the bug

Although in ./application/Espo/Core/Portal/ApplicationRunners/Client.php there's still the attribute:

 'appClientClassName' => 'app-portal',

It is not used anymore in the <body> element of EspoCRM.

I noticed this as from version 8.0.6 of EspoCRM, while upgrading from version 6.1.8.

I depend on this class in my custom css file to be able to customize the portal look and feel for my client.

To Reproduce (MANDATORY, DO NOT REMOVE) Explicit steps to reproduce the behavior:

  1. Run version 6.1.8 of EspoCRM.
  2. In the normal CRM mode, <body> will contain class classname="app". In the portal mode, <body> will contain classname="app-portal".
  3. Run version 8.0.6 of EspoCRM.
  4. Both classname="app" and classname="app-portal" have disappeared and are replaced by classname="has-navbar".

Expected behavior I would expect something like 

<body classname="app has-navbar" ...>

for the normal CRM, and

<body classname="app-portal has-navbar" ...>

for the portal CRM.

Screenshots not applicable.

EspoCRM version I noticed this in version 8.0.6. I'm still upgrading to the following versions, until 8.3.x, so I currently don't know if this has been noticed and solved.

Additional context

yurikuzn commented 1 month ago

I don't remember we ever had appClientClassName added to an element class list. It refers to a JS class (ID), not CSS.

yurikuzn commented 1 month ago

I suspect that was your customization. https://github.com/espocrm/espocrm/issues/1884

hdijkema commented 1 month ago

I stand corrected. My apologies. I made a customization of html/main.html indeed. Added a class there. It's never good to do put customizations directly in the source of EspoCRM.

Still a question though. In commit d7b9b65 there's an application id in the body tag.

image

I recon this is for version 8.4 of EspoCRM?

yurikuzn commented 1 month ago

8.3

image

hdijkema commented 1 month ago

Thanks!