search

espositos / fvtt-tokenactionhud

Creating a token action HUD module for Foundry VTT
31 stars 38 forks source link

Add support request for EndlesNights dnd4ebeta system #162

Open NuptupTDOW opened 3 years ago

NuptupTDOW commented 3 years ago

It would be greatly appreciated if this system https://github.com/EndlesNights/dnd4eBeta could get support. It should be very simple as it runs off of a modified simple world building system. I would love to help in any way I can. You can find me in the foundryvtt discord. Feel free to send me a direct message if that's easier!

espositos commented 3 years ago

Hi there, sorry, at the moment I just have no time to support new systems. To explain, I'm in corona lockdown and trying to work full-time from home with a couple of screaming kids, including a newborn. I welcome pull requests, but I'm afraid any implementation provided by me will take a long time.

NuptupTDOW commented 3 years ago

I'm fairly new to using github, but i can certainly try to brute force my way through converting the code over to that system, not like i have anything else occupying my time. Just need a nugget of direction. What is a "pull request"? last time I modified a module i made a copy then sent the modifications to the owner manually. But, I'm willing to learn the more proper way to ease the hassle on you. Just new to github as a whole and not sure how to implement it.

espositos commented 3 years ago

You can send me your changes manually as well, either on Discord (^ and stick#0520) or upload it here and I can import it. Otherwise, a pull request is where you fork this repository (make a copy for your own github account), make your changes there, and then request that I merge your changes into my repository. I wouldn't worry about that if you're new to github.

And please don't get me wrong, I really appreciate the interest and the effort you're willing to go, but just be aware that I don't want to take something half baked and then invest as much time supporting that as I would doing the original work myself.

NuptupTDOW commented 3 years ago

You can send me your changes manually as well, either on Discord (^ and stick#0520) or upload it here and I can import it. Otherwise, a pull request is where you fork this repository (make a copy for your own github account), make your changes there, and then request that I merge your changes into my repository. I wouldn't worry about that if you're new to github.

And please don't get me wrong, I really appreciate the interest and the effort you're willing to go, but just be aware that I don't want to take something half baked and then invest as much time supporting that as I would doing the original work myself.

So, I have tried my best to wrap my head around how this works and I just can't figure it out. Would it be at all possible to just pay you for a conversion of it so it works with the system on a base level. I genuinely love the module, and I miss it EVERY session, but i have poured more time than I'd like to admit trying to convert it over and I just get so disappointed trying to convert it over and I'd gladly pay for it since I know others would use it too. I know you mentioned you were busy, if you aren't able or interested, could you maybe point me in the direction of someone you know has had success implementing other systems in the past so I can explore that avenue?