search

espositos / fvtt-tokenactionhud

Creating a token action HUD module for Foundry VTT
31 stars 38 forks source link

Show pathfinder 1e skills if training not required. #178

Closed moorepants closed 3 years ago

moorepants commented 3 years ago

Pathfinder 1e has the concept of trained/untrained skills, as mentioned in #175. A change was made (https://github.com/espositos/fvtt-tokenactionhud/commit/59dfefe094a56b1771c30acd4c816c7a8605d3e5) to show only skills that have rank != 0, but skills that don't need training should also be shown. I think this should fix things, but I'm new to foundry dev and haven't yet figured out how to test it locally (don't know how to install development modules).

moorepants commented 3 years ago

Figured out how to get things installed and tested it. Here is a screenshot: Screenshot from 2021-02-27 11-38-05

Note that, for example, Acrobatics has no rank, but doesn't require training. So it shows up in the HUD but Disable Device requires training and has no rank, so it does not show up in the HUD. So, the behavior should now be correct.

espositos commented 3 years ago

That's great, thank you!