search

espositos / fvtt-tokenactionhud

Creating a token action HUD module for Foundry VTT
31 stars 38 forks source link

PF2E: Saving throws not displaying modifiers #193

Closed itrase closed 3 years ago

itrase commented 3 years ago

The top roll is from TokenActionHUD, the bottom is by clicking in the character sheet. The rolls are being calculated correctly, the modifier boxes just aren't showing up. Capture

JonWaterfall commented 3 years ago

It seems to happen for monsters, but not for players.

Unless your players are using monster sheets I don't think it shouldn't be a problem.

itrase commented 3 years ago

true, but it helps the GM to see what modifiers are effecting the monsters, which is useful. Also, it seems to be a one-line fix in the PF2E rollHandler. from:

   _rollSaveNpc(event, actor, actionId) {
        actor.rollSave(event, actionId);
    }

to:

    _rollSaveNpc(event, actor, actionId) {
    actor.data.data.saves[actionId].roll(event);
    }

would fix it.

espositos commented 3 years ago

Thanks, itrase, I'll post a patch