search

espositos / fvtt-tokenactionhud

Creating a token action HUD module for Foundry VTT
31 stars 38 forks source link

Fix missing changes for 0.8.x support #235

Closed p-becker closed 3 years ago

p-becker commented 3 years ago

Went off the console errors and just copy pasted changes i saw in https://github.com/espositos/fvtt-tokenactionhud/commit/bd9380a51af2eec0e4a146bed93da9abce891ed7

Successfully tested with 0.8.5

espositos commented 3 years ago

Thanks for the help, missed those things.

espositos commented 3 years ago

The reason for using _getEntityData at the moment was (and should be) to support 0.7.x and 0.8.x simultaneously. The location of a lot of the data seems to have migrated in 0.8.x and as I understand it I need to check in two places to see where the data is. In 0.7.x it is in item.data (most of the time) and in 0.8.x it has been standardised so it is in data.data. getEntityData makes a check to see which is there.

Some things, like flags, are still stored in .data not .data.data, so that will still be used, and some more general details like names are often available in .data too. This is all speculation, because I haven't really had time to look into it. But thank you for patching it so it is working anyway :)