search

espositos / fvtt-tokenactionhud

Creating a token action HUD module for Foundry VTT
31 stars 38 forks source link

Spells category not appearing for tokens with only "always prepared" spells. #240

Closed Battenhatch closed 3 years ago

Battenhatch commented 3 years ago

HUD is now appearing for all characters, which is great. One little corner remains, though - the Spells category doesn't seem to appear if a character has only "Always Prepared" spells, like a Bard, Sorcerer or Ranger - this is true for me in two different campaigns.

Battenhatch commented 3 years ago

Oh, and the system doesn't throw any error messages regarding this.

p-becker commented 3 years ago

Which fvtt and module version are you using? Possibly related to #239

espositos commented 3 years ago

Yes, the prepared notation might have moved. I will look at it this evening.

espositos commented 3 years ago

Because I'm not sure how multiclassing interacts with this, I'm hesitant to use this option over setting spells to 'always prepared' per the option in the spell configuration.

image

If you have a multiclass sorcerer/wizard, I assume that not every spell should be 'always prepared'? Otherwise you could have a Sor 1/Wiz 19 who has an entire library of spells that are always prepared, even though they only have two first level Sorc slots. If it's a complex interaction between preparedness and class, I don't want to show all spells simply because that actor has a particular class.

However, I'd be happy to hear arguments.

espositos commented 3 years ago

Regarding 'always prepared' spells not showing, this was a bug that I think I've fixed in the latest patch, but it needs to be set explicitly on the spell. Again, if it's not working for you and you're using the latest patch, let me know.

p-becker commented 3 years ago

Good points. Using that menu seems fine with me so I'll abort the PR. You seem to have fixed the initial issue here, can't reproduce it with proper spell settings :)

Battenhatch commented 3 years ago

"Spells" still not showing at my end with latest update, if spells are "Always Prepared".

espositos commented 3 years ago

shakes fist at sky okay, I'll look at it

Battenhatch commented 3 years ago

The problem turns out to not what I thought - it's not wether it's "always prepared" or not - it about the "prepared" checkbox next to the field where the preparedness level is set. This need to be checked for at spell to be included in the "Spells" category. The characters where the category didn't show had none of these boxes checked.

checkbox

Battenhatch commented 3 years ago

And no, it wasn't even that - it was a d*** module settings issue, and thus not an issue - well, you learn something new every day :)