search

espositos / fvtt-tokenactionhud

Creating a token action HUD module for Foundry VTT
31 stars 38 forks source link

Inventory items no longer working #259

Open techogre opened 3 years ago

techogre commented 3 years ago

Environment Details

Foundry VTT Version: 0.8.6 Operating System: Ubuntu 20.04 on a Raspberry Pi 3 B+ How Are You Using Foundry: Nodes.js service Modules Enabled?:

Issue Description

When an actor is selected and one of the items under Inventory is selected, I get the following error in the console:

2swade-br2sw.js:57 Uncaught (in promise) TypeError: game.brsw.create_item_card_fromid is not a function at RollHandlerBR2SWSwade._rollItem (swade-br2sw.js:57) at RollHandlerBR2SWSwade.doHandleActionEvent (swade-br2sw.js:28) at RollHandlerBR2SWSwade.handleActionEvent (rollHandler.js:47) at handleClick (tokenactionhud.js:100) at HTMLDivElement. (tokenactionhud.js:107) at HTMLDivElement.dispatch (jquery.min.js:2) at HTMLDivElement.v.handle (jquery.min.js:2)

It was working with the previous version.

Relevant logs and/or screenshots

n/a

Possible Solution and/or Root Cause

Could be an issue with Better Rolls 2 for Savage Worlds not working with your new update.

/label ~bug

Blesmol commented 3 years ago

Same here using Foundry v0.7.10 hosted on TheForge and latest release (1.0.30) of Token Action HUB. Issue was also present with the version of TAH that is used before, 1.0.25.

Game system is DnD5.

Overlap on my side with module list above is:

Console error

Uncaught (in promise) TypeError: item is null
    needsRecharge dnd5e-base.js:102
    rollItemMacro dnd5e-base.js:90
    _handleMacros dnd5e-base.js:51
    doHandleActionEvent dnd5e-base.js:27
    handleActionEvent rollHandler.js:47
    handleClick tokenactionhud.js:100
    activateListeners tokenactionhud.js:107
    jQuery 8
    activateListeners tokenactionhud.js:106
    _render foundry.js:4537
    call_wrapped libWrapper-wrapper.js:449
    <anonymous> libWrapper-errors.js:268
    0 libWrapper-wrapper.js:143
    render foundry.js:4479
    updateHud tokenactionhud.js:394
    setTimeout handler*update tokenactionhud.js:377
    <anonymous> init.js:33
    _call lib-wrapper.js line 1 > eval:4
    callAll foundry.js:2456
    control foundry.js:11629
    _onClickLeft foundry.js:11858
    _onClickLeft foundry.js:45403
    callback foundry.js:36410
    _handleClickLeft foundry.js:36598
    _handleMouseDown foundry.js:36578
    emit index.js:181
    dispatchEvent InteractionManager.ts:1106
    processPointerDown InteractionManager.ts:1307
    recursiveFindHit TreeSearch.ts:173
    recursiveFindHit TreeSearch.ts:113
    recursiveFindHit TreeSearch.ts:113
    recursiveFindHit TreeSearch.ts:113
    findHit TreeSearch.ts:200
    processInteractive InteractionManager.ts:1177
    onPointerDown InteractionManager.ts:1252
dnd5e-base.js:102:9
    doHandleActionEvent dnd5e-base.js:27
    AsyncFunctionThrow self-hosted:699
    (Async: async)
    handleActionEvent rollHandler.js:47
    handleClick tokenactionhud.js:100
    activateListeners tokenactionhud.js:107
    jQuery 8
    activateListeners tokenactionhud.js:106
    _render foundry.js:4537
    AsyncFunctionNext self-hosted:695
    (Async: async)
    call_wrapped libWrapper-wrapper.js:449
    call_wrapped self-hosted:1282
    <anonymous> libWrapper-errors.js:268
    wrapper self-hosted:1225
    0 libWrapper-wrapper.js:143
    render foundry.js:4479
    updateHud tokenactionhud.js:394
    InterpretGeneratorResume self-hosted:1485
    AsyncFunctionNext self-hosted:695
    (Async: async)
    updateHud self-hosted:1178
    (Async: setTimeout handler)
    update tokenactionhud.js:377
    <anonymous> init.js:33
    _call lib-wrapper.js line 1 > eval:4
    callAll foundry.js:2456
    control foundry.js:11629
    _onClickLeft foundry.js:11858
    _onClickLeft foundry.js:45403
    callback foundry.js:36410
    _handleClickLeft foundry.js:36598
    _handleMouseDown foundry.js:36578
    _handleMouseDown self-hosted:1178
    emit index.js:181
    dispatchEvent InteractionManager.ts:1106
    processPointerDown InteractionManager.ts:1307
    <anonymous> self-hosted:1178
    recursiveFindHit TreeSearch.ts:173
    recursiveFindHit TreeSearch.ts:113
    recursiveFindHit TreeSearch.ts:113
    recursiveFindHit TreeSearch.ts:113
    findHit TreeSearch.ts:200
    processInteractive InteractionManager.ts:1177
    onPointerDown InteractionManager.ts:1252
    <anonymous> self-hosted:1178
Blesmol commented 3 years ago

Basically the same also not only for items, but also for spells in DnD5

espositos commented 3 years ago

If you are using 0.7.10 for the Foundry version, please downgrade the HUD to 1.0.19 at the moment. I think I have managed to mangle some things in supporting 0.8.x

espositos commented 3 years ago

@techogre I am not sure about your issue, I will have to investigate later this week.

Blesmol commented 3 years ago

@espositos Thanks for the hint! Will give it a try (as soon as I find out on how to get older module versions on the Forge).

BTW: Would probably be good to add some hint to the metadata files of the older releases that they are not compatible with 0.8.x... might avoid a couple of GH issues in the near future ;-)

Blesmol commented 3 years ago

@espositos Can confirm that downgrading to 1.0.19 solved the issue for me. Thanks again!

espositos commented 3 years ago

@espositos Thanks for the hint! Will give it a try (as soon as I find out on how to get older module versions on the Forge).

BTW: Would probably be good to add some hint to the metadata files of the older releases that they are not compatible with 0.8.x... might avoid a couple of GH issues in the near future ;-)

a sensible suggestion, i will do that although i hope it's temporary