File with CSS white space is not shown

esprehn / chromium-codereview

A chrome extension that changes the frontend to Rietveld for Chromium

Other

35 stars 11 forks source link

Open jchaffraix opened 9 years ago

jchaffraix commented 9 years ago

How to reproduce:

Open https://codereview.chromium.org/558163004/
Click on "Show diffs" on patchset 3
Observe that LayoutTests/fast/css-grid-layout/grid-template-areas-empty-string-crash.html has no content, though if you check the raw diff you can see the content.

esprehn commented 9 years ago

I fixed this.

esprehn commented 9 years ago

Err, no I didn't, on Patchset 3 I see:

Parse error: Unable to classify line: '";'

the raw diff shows a line in the diff that doesn't have a + or a - which is really weird. I wonder how you're supposed to classify that line.

esprehn commented 9 years ago

Rietveld also thinks that diff is invalid. Weird.