search

esprehn / chromium-codereview

A chrome extension that changes the frontend to Rietveld for Chromium
Other
35 stars 11 forks source link

Single file view #117

Open sdefresne opened 9 years ago

sdefresne commented 9 years ago

The review tool should provide a single file view to allow reviewing complex files, or change lists. One use case is to have the ability to see a new API and its usage and switch between them in two different tabs (scrolling is too slow and means losing context).

esprehn commented 9 years ago

What do you mean scrolling is too slow?

sdefresne commented 9 years ago

Take a look at https://codereview.chromium.org/812823002 for example. When I review such a large patch, I want to be able to see both the API that is changed (in components/infobars/core/infobar_manager.h and components/infobars/core/confirm_infobar_delegate.h) and the changes in the client code.

Scrolling between the impacted client code, and the changed header file to check that everything is correct is not really practical. I cannot see at a glance that everything is fine. By too slow, I do not mean in technical sense, just that it is long enough (and error prone enough) that I can loose the context.

With the old tool, I can just ctrl+click on a file and then keep it open in another tab while I review the client changes. With the new tool, ctrl+click just unfold the diff for that file, so I need to go to the url bar, copy it, open a new tab, past the copied url, and unfold the diff for the file I'm interested in.