Silently dropping lines in diff.

esprehn / chromium-codereview

A chrome extension that changes the frontend to Rietveld for Chromium

Other

35 stars 11 forks source link

Silently dropping lines in diff. #120

Open jcgregorio opened 9 years ago

jcgregorio commented 9 years ago

Visit this issue and view monitoring/go/datahopper/main.go in the new (non-deprecated) UI.

https://codereview.chromium.org/761433005/

You will notice line 35 in the left hand column is missing. I also believe the line numbers around line 35 on the right hand column are wrong. You can actually see a line is missing by switching back to the deprecated UI and see that line 37:

 common.InitWithMetrics("datahopper", *graphiteServer)

is there, but that line missing in the new UI.

esprehn commented 9 years ago

I really need a better API to get context from the server, I'm parsing the existing context responses, but it's very buggy. I'd be much better if I could just download the base files. @aarongable