Change list should list files in alphabetic order

esprehn / chromium-codereview

A chrome extension that changes the frontend to Rietveld for Chromium

Other

35 stars 11 forks source link

Change list should list files in alphabetic order #121

Closed sdefresne closed 9 years ago

sdefresne commented 9 years ago

Files seems to be in a random order (see for example last patch of https://codereview.chromium.org/777863002).

Order is: components/autofill/core/browser/autocomplete_history_manager_unittest.cc components/components.gyp components/autofill/core/browser/DEPS ...

This does not make any sense.

esprehn commented 9 years ago

Yeah PatchFile.compare is busted, need to come up with a better way to do this fancy sorting.

esprehn commented 9 years ago

Fixed by https://codereview.chromium.org/992403002