search

esprehn / chromium-codereview

A chrome extension that changes the frontend to Rietveld for Chromium
Other
35 stars 11 forks source link

Less whitespace please? #124

Open jyasskin opened 9 years ago

jyasskin commented 9 years ago

The new Rietveld UI has 1em of space between each line of text (Owner, Created, Modified, CQ, etc.) and .65em extra space between each line inside a paragraph, which means I can't see the full file list and test results above the fold. The spacing appears to be in line with the Material Design guidelines, but unlike with gmail, Rietveld doesn't have the excuse that its primary users are non-programmers or that most users have short lists to read.

esprehn commented 9 years ago

Can you give an example issue and what screen resolution your'e at?

This isn't about non-programmers, this is about having an interface that's readable (ex. this bug tracker). Note that the difference between the old Rietveld and the new one is usually around 50-100px between the top of the file list and once you have multiple patchsets the new tool is actually much better about keeping things farther up the screen.

jyasskin commented 9 years ago

I'm on a Macbook Pro at 2880 x 1800.

Old: s7etvv1fvq New: odxeerlxk2

If we're treating github as the gold standard for readability, their file list has 26px entries vs new-Rietveld's 34px. Their code lines are 18px high vs our 21px. Their comment text has a line-height of 22.4px vs our 21.5px and Material Design's 20px leading, but they use sans-serif vs our monospace, which saves so much horizontal space that it winds up saving vertical space too.

The New UI is much better in many ways; I'm objecting that it's using all the saved space to show us more whitespace instead of more information. I did discover that if I zoom out to ~75%, the UI gets more usable, although I'd still prefer replacing some of the whitespace with less-shrunk characters: u3j0rxnhcg