esprehn / chromium-codereview

A chrome extension that changes the frontend to Rietveld for Chromium
Other
35 stars 11 forks source link

File comment should be visible #127

Closed sdefresne closed 9 years ago

sdefresne commented 9 years ago

The old UI of the review system allowed to add file level comment (i.e. comment on the file, not a particular line). The new UI does not display those comments inline. It just leave a mark there is a comment on the file, but when you expand it, you cannot see it.

See for example https://codereview.chromium.org/813503003/

esprehn commented 9 years ago

I'm not aware of file level comments in the old UI, but there are comments outside the diff range there. They won't show up until you expand context.