search

esprehn / chromium-codereview

A chrome extension that changes the frontend to Rietveld for Chromium
Other
35 stars 11 forks source link

Make comments linkable #52

Closed quisquous closed 10 years ago

quisquous commented 10 years ago

I don't know what I'm doing, but this looks like it does the right thing. :)

quisquous commented 10 years ago

Not sure if you need a comment here to get an email, but PTAL at the latest changes. :)

esprehn commented 10 years ago

Apparently it doesn't send emails :/ I'm really surprised that the commas in the attributes attr on work. They're definitely not needed. I also see that the comment headers are yellow even for lgtm comments, but Rietveld did that too.

quisquous commented 10 years ago

Yeah, I didn't know what to do about collisions between lgtm and selected colors, but it seemed like selected should win. I could find some other style too, but maybe that'd be confusing to have both. shrug