search

esprehn / chromium-codereview

A chrome extension that changes the frontend to Rietveld for Chromium
Other
35 stars 11 forks source link

Diff display should show comments outside the diff range #84

Open jeisinger opened 10 years ago

jeisinger commented 10 years ago

e.g. in https://codereview.chromium.org/393123005/ when you click on show diffs for patchset 1, the comment in line 35 is not shown

esprehn commented 10 years ago

I'll have to think about this, it's unfortunately not easy since it requires loading sections of the file that are not in the diff.