search

esprehn / chromium-codereview

A chrome extension that changes the frontend to Rietveld for Chromium
Other
35 stars 11 forks source link

No warning when publishing with unsaved drafts #87

Open esprehn opened 10 years ago

esprehn commented 10 years ago

Quoting @natduca

If you have a draft comment [eg you didn't press save], then you press 'publish' then it sends the saved comments but not the drafts.

Repro steps:

  1. click a line to add feedback. write a bit. Do not press save.
  2. publish comments.

Expected behavior: tool complains that there unsent drafts. Actual behavior: the unsent draft is lost, and the message is posted with the comments that were saved.