search

esprehn / chromium-codereview

A chrome extension that changes the frontend to Rietveld for Chromium
Other
35 stars 11 forks source link

"edit" link for CL description is off-screen to the right. #94

Closed chrishtr closed 10 years ago

chrishtr commented 10 years ago

Instead it needs to be vertically aligned with the "Settings" link in the top bar.

esprehn commented 10 years ago

Have an example link? I don't see that.

chrishtr commented 10 years ago

It happens for e.g. https://codereview.chromium.org/520803004/ (but any code review). On 38.0.2125.0 (dev). Maybe it's a Chrome bug? The reviewer emails also have no space between them in the layout.

On Thu Aug 28 2014 at 7:58:45 PM Elliott Sprehn notifications@github.com wrote:

Have an example link? I don't see that.

— Reply to this email directly or view it on GitHub https://github.com/esprehn/chromium-codereview/issues/94#issuecomment-53832149 .

esprehn commented 10 years ago

This was vulcanizer, I was passing --strip which removed all the whitespace and broke things. I've turned that off for now. Fixed by https://github.com/esprehn/chromium-codereview/commit/61ef3f6011af1f7bbcf7c8bd66bd72aecb127f72