espressif / arduino-esp32

Arduino core for the ESP32
GNU Lesser General Public License v2.1
13.75k stars 7.44k forks source link

fix(networking): NetworkClientRxBuffer::clear() may not always clear #10331

Closed TD-er closed 2 months ago

TD-er commented 2 months ago

Description of Change

See discussion in issue #10288

Related links

Fixes: #10288

github-actions[bot] commented 2 months ago
Warnings
:warning: **Some issues found for the commit messages in this PR:** - the commit message `"NetworkClientRxBuffer::clear() may not always clear (#10288)"`: - *summary* looks empty - *type/action* looks empty *** **Please fix these commit messages** - here are some basic tips: - follow [Conventional Commits style](https://www.conventionalcommits.org/en/v1.0.0/) - correct format of commit message should be: `(): `, for example `fix(esp32): Fixed startup timeout issue` - allowed types are: `change,ci,docs,feat,fix,refactor,remove,revert,test` - sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter - avoid Jira references in commit messages (unavailable/irrelevant for our customers) `TIP:` Install pre-commit hooks and run this check when committing (uses the [Conventional Precommit Linter](https://github.com/espressif/conventional-precommit-linter)).

πŸ‘‹ Hello TD-er, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by :no_entry_sign: dangerJS against 2835ceb9e8fdccc00ddc2d2f96afa098719c56db

github-actions[bot] commented 2 months ago

Test Results

 56 files   -β€Šβ€‡83   56 suites   -β€Š83   4m 55s :stopwatch: - 1h 37m 28s  21 tests  -β€Šβ€‡β€‡9   21 :white_check_mark:  -β€Šβ€‡β€‡9  0 :zzz: Β±0  0 :x: Β±0  135 runsβ€Š  -β€Š168  135 :white_check_mark:  -β€Š168  0 :zzz: Β±0  0 :x: Β±0 

Results for commit 2835ceb9. ± Comparison against base commit 4e9eb357.

This pull request removes 9 tests. ``` performance.coremark.test_coremark ‑ test_coremark performance.fibonacci.test_fibonacci ‑ test_fibonacci performance.psramspeed.test_psramspeed ‑ test_psramspeed performance.ramspeed.test_ramspeed ‑ test_ramspeed performance.superpi.test_superpi ‑ test_superpi test_touch_errors test_touch_interrtupt test_touch_read validation.periman.test_periman ‑ test_periman ```

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 months ago

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S3:green_heart: -16:warning: +120.000.00000.000.00
ESP32S2:green_heart: -24:warning: +120.000.00000.000.00
ESP32C30:warning: +120.000.00000.000.00
ESP32C60:warning: +100.000.00000.000.00
ESP32H20:warning: +100.000.00000.000.00
ESP320:warning: +160.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
Ethernet/examples/ETH_W5500_Arduino_SPI0000:warning: +100:warning: +100:warning: +100:warning: +160
Ethernet/examples/ETH_W5500_IDF_SPI0000:warning: +100:warning: +100:warning: +100:warning: +120
Ethernet/examples/ETH_WIFI_BRIDGE00000000--00
NetworkClientSecure/examples/WiFiClientInsecure0000:warning: +100:warning: +100--:warning: +120
NetworkClientSecure/examples/WiFiClientPSK0000:warning: +100:warning: +100--:warning: +120
NetworkClientSecure/examples/WiFiClientSecure0000:warning: +100:warning: +100--:warning: +120
NetworkClientSecure/examples/WiFiClientSecureEnterprise0000:warning: +100:warning: +100--:warning: +120
NetworkClientSecure/examples/WiFiClientSecureProtocolUpgrade00:warning: +120:warning: +100:warning: +100--:warning: +120
NetworkClientSecure/examples/WiFiClientShowPeerCredentials:green_heart: -16000:warning: +100:warning: +100--:warning: +120
NetworkClientSecure/examples/WiFiClientTrustOnFirstUse0000:warning: +100:warning: +100--00
PPP/examples/PPP_Basic0000:warning: +100:warning: +100:warning: +100:warning: +120
PPP/examples/PPP_WIFI_BRIDGE00000000--00
WebServer/examples/AdvancedWebServer0000:warning: +100:warning: +100--:warning: +120
WebServer/examples/FSBrowser0000:warning: +100:warning: +100--:warning: +120
WebServer/examples/Filters:warning: +40:warning: +120:warning: +100:warning: +100--:warning: +120
WebServer/examples/HelloServer0000:warning: +100:warning: +100--:warning: +120
WebServer/examples/HttpAdvancedAuth0000:warning: +100:warning: +100--:warning: +120
WebServer/examples/HttpAuthCallback0000:warning: +100:warning: +100--:warning: +120
WebServer/examples/HttpAuthCallbackInline0000:warning: +100:warning: +100--:warning: +120
WebServer/examples/HttpBasicAuth0000:warning: +100:warning: +100--:warning: +120
WebServer/examples/HttpBasicAuthSHA10000:warning: +120:warning: +100--:warning: +120
WebServer/examples/HttpBasicAuthSHA1orBearerToken0000:warning: +100:warning: +100--:warning: +120
WebServer/examples/MultiHomedServers00:warning: +120:warning: +100:warning: +100--:warning: +120
WebServer/examples/PathArgServer:warning: +12000:warning: +100:warning: +100--:warning: +120
WebServer/examples/SDWebServer0000:warning: +100:warning: +100--:warning: +120
WebServer/examples/SimpleAuthentification0000:warning: +100:warning: +100--:warning: +160
WebServer/examples/UploadHugeFile00:green_heart: -240:warning: +100:warning: +100--00
WebServer/examples/WebServer:warning: +12000:warning: +100:warning: +100--:warning: +40
WebServer/examples/WebUpdate0000:warning: +100:warning: +100--:warning: +120
WiFi/examples/FTM/FTM_Initiator00000000--00
WiFi/examples/FTM/FTM_Responder00000000--00
WiFi/examples/SimpleWiFiServer:warning: +12000:warning: +100:warning: +100--:warning: +120
WiFi/examples/WPS00000000--00
WiFi/examples/WiFiAccessPoint0000:warning: +100:warning: +100--:warning: +160
WiFi/examples/WiFiBlueToothSwitch00--0000--00
WiFi/examples/WiFiClient0000:warning: +100:warning: +100--:warning: +120
WiFi/examples/WiFiClientBasic0000:warning: +100:warning: +100--:warning: +120
WiFi/examples/WiFiClientConnect00000000--00
WiFi/examples/WiFiClientEnterprise0000:warning: +100:warning: +100--:warning: +120
WiFi/examples/WiFiClientEvents00000000--00
WiFi/examples/WiFiClientStaticIP:warning: +12000:warning: +100:warning: +100--:warning: +120
WiFi/examples/WiFiExtender00000000--00
WiFi/examples/WiFiIPv600000000--00
WiFi/examples/WiFiMulti00000000--00
WiFi/examples/WiFiMultiAdvanced0000:warning: +100:warning: +100--:warning: +120
WiFi/examples/WiFiScan00000000--00
WiFi/examples/WiFiScanAsync00000000--00
WiFi/examples/WiFiScanDualAntenna00000000--00
WiFi/examples/WiFiScanTime00000000--00
WiFi/examples/WiFiSmartConfig00000000--00
WiFi/examples/WiFiTelnetToSerial0000:warning: +100:warning: +100--:warning: +120
WiFi/examples/WiFiUDPClient00000000--00
Ethernet/examples/ETH_LAN8720----------:warning: +120
Ethernet/examples/ETH_TLK110----------:warning: +120