Closed TD-er closed 2 months ago
Warnings | |
---|---|
:warning: |
**Some issues found for the commit messages in this PR:**
- the commit message `"NetworkClientRxBuffer::clear() may not always clear (#10288)"`:
- *summary* looks empty
- *type/action* looks empty
***
**Please fix these commit messages** - here are some basic tips:
- follow [Conventional Commits style](https://www.conventionalcommits.org/en/v1.0.0/)
- correct format of commit message should be: ` |
π Hello TD-er, we appreciate your contribution to this project!
This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.
DangerJS is triggered with each push
event to a Pull Request and modify the contents of this comment.
Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (β οΈ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.
We do welcome contributions in the form of bug reports, feature requests and pull requests.
1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.
Generated by :no_entry_sign: dangerJS against 2835ceb9e8fdccc00ddc2d2f96afa098719c56db
β56 filesβ β-ββ83βββ56 suitesβ β-β83βββ4m 55s :stopwatch: - 1h 37m 28s β21 tests β-βββ9βββ21 :white_check_mark: β-βββ9ββ0 :zzz: Β±0ββ0 :x: Β±0β 135 runsβ β-β168ββ135 :white_check_mark: β-β168ββ0 :zzz: Β±0ββ0 :x: Β±0β
Results for commit 2835ceb9.βΒ± Comparison against base commit 4e9eb357.
:recycle: This comment has been updated with latest results.
The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Memory | FLASH [bytes] | FLASH [%] | RAM [bytes] | RAM [%] | ||||
---|---|---|---|---|---|---|---|---|
Target | DEC | INC | DEC | INC | DEC | INC | DEC | INC |
ESP32S3 | :green_heart: -16 | :warning: +12 | 0.00 | 0.00 | 0 | 0 | 0.00 | 0.00 |
ESP32S2 | :green_heart: -24 | :warning: +12 | 0.00 | 0.00 | 0 | 0 | 0.00 | 0.00 |
ESP32C3 | 0 | :warning: +12 | 0.00 | 0.00 | 0 | 0 | 0.00 | 0.00 |
ESP32C6 | 0 | :warning: +10 | 0.00 | 0.00 | 0 | 0 | 0.00 | 0.00 |
ESP32H2 | 0 | :warning: +10 | 0.00 | 0.00 | 0 | 0 | 0.00 | 0.00 |
ESP32 | 0 | :warning: +16 | 0.00 | 0.00 | 0 | 0 | 0.00 | 0.00 |
Target | ESP32S3 | ESP32S2 | ESP32C3 | ESP32C6 | ESP32H2 | ESP32 | ||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
Example | FLASH | RAM | FLASH | RAM | FLASH | RAM | FLASH | RAM | FLASH | RAM | FLASH | RAM |
Ethernet/examples/ETH_W5500_Arduino_SPI | 0 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | :warning: +16 | 0 |
Ethernet/examples/ETH_W5500_IDF_SPI | 0 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | :warning: +12 | 0 |
Ethernet/examples/ETH_WIFI_BRIDGE | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | - | - | 0 | 0 |
NetworkClientSecure/examples/WiFiClientInsecure | 0 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +12 | 0 |
NetworkClientSecure/examples/WiFiClientPSK | 0 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +12 | 0 |
NetworkClientSecure/examples/WiFiClientSecure | 0 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +12 | 0 |
NetworkClientSecure/examples/WiFiClientSecureEnterprise | 0 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +12 | 0 |
NetworkClientSecure/examples/WiFiClientSecureProtocolUpgrade | 0 | 0 | :warning: +12 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +12 | 0 |
NetworkClientSecure/examples/WiFiClientShowPeerCredentials | :green_heart: -16 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +12 | 0 |
NetworkClientSecure/examples/WiFiClientTrustOnFirstUse | 0 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | 0 | 0 |
PPP/examples/PPP_Basic | 0 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | :warning: +12 | 0 |
PPP/examples/PPP_WIFI_BRIDGE | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | - | - | 0 | 0 |
WebServer/examples/AdvancedWebServer | 0 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +12 | 0 |
WebServer/examples/FSBrowser | 0 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +12 | 0 |
WebServer/examples/Filters | :warning: +4 | 0 | :warning: +12 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +12 | 0 |
WebServer/examples/HelloServer | 0 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +12 | 0 |
WebServer/examples/HttpAdvancedAuth | 0 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +12 | 0 |
WebServer/examples/HttpAuthCallback | 0 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +12 | 0 |
WebServer/examples/HttpAuthCallbackInline | 0 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +12 | 0 |
WebServer/examples/HttpBasicAuth | 0 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +12 | 0 |
WebServer/examples/HttpBasicAuthSHA1 | 0 | 0 | 0 | 0 | :warning: +12 | 0 | :warning: +10 | 0 | - | - | :warning: +12 | 0 |
WebServer/examples/HttpBasicAuthSHA1orBearerToken | 0 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +12 | 0 |
WebServer/examples/MultiHomedServers | 0 | 0 | :warning: +12 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +12 | 0 |
WebServer/examples/PathArgServer | :warning: +12 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +12 | 0 |
WebServer/examples/SDWebServer | 0 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +12 | 0 |
WebServer/examples/SimpleAuthentification | 0 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +16 | 0 |
WebServer/examples/UploadHugeFile | 0 | 0 | :green_heart: -24 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | 0 | 0 |
WebServer/examples/WebServer | :warning: +12 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +4 | 0 |
WebServer/examples/WebUpdate | 0 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +12 | 0 |
WiFi/examples/FTM/FTM_Initiator | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | - | - | 0 | 0 |
WiFi/examples/FTM/FTM_Responder | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | - | - | 0 | 0 |
WiFi/examples/SimpleWiFiServer | :warning: +12 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +12 | 0 |
WiFi/examples/WPS | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | - | - | 0 | 0 |
WiFi/examples/WiFiAccessPoint | 0 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +16 | 0 |
WiFi/examples/WiFiBlueToothSwitch | 0 | 0 | - | - | 0 | 0 | 0 | 0 | - | - | 0 | 0 |
WiFi/examples/WiFiClient | 0 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +12 | 0 |
WiFi/examples/WiFiClientBasic | 0 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +12 | 0 |
WiFi/examples/WiFiClientConnect | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | - | - | 0 | 0 |
WiFi/examples/WiFiClientEnterprise | 0 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +12 | 0 |
WiFi/examples/WiFiClientEvents | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | - | - | 0 | 0 |
WiFi/examples/WiFiClientStaticIP | :warning: +12 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +12 | 0 |
WiFi/examples/WiFiExtender | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | - | - | 0 | 0 |
WiFi/examples/WiFiIPv6 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | - | - | 0 | 0 |
WiFi/examples/WiFiMulti | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | - | - | 0 | 0 |
WiFi/examples/WiFiMultiAdvanced | 0 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +12 | 0 |
WiFi/examples/WiFiScan | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | - | - | 0 | 0 |
WiFi/examples/WiFiScanAsync | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | - | - | 0 | 0 |
WiFi/examples/WiFiScanDualAntenna | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | - | - | 0 | 0 |
WiFi/examples/WiFiScanTime | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | - | - | 0 | 0 |
WiFi/examples/WiFiSmartConfig | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | - | - | 0 | 0 |
WiFi/examples/WiFiTelnetToSerial | 0 | 0 | 0 | 0 | :warning: +10 | 0 | :warning: +10 | 0 | - | - | :warning: +12 | 0 |
WiFi/examples/WiFiUDPClient | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | - | - | 0 | 0 |
Ethernet/examples/ETH_LAN8720 | - | - | - | - | - | - | - | - | - | - | :warning: +12 | 0 |
Ethernet/examples/ETH_TLK110 | - | - | - | - | - | - | - | - | - | - | :warning: +12 | 0 |
Description of Change
See discussion in issue #10288
Related links
Fixes: #10288