search

espressif / arduino-esp32

Arduino core for the ESP32
GNU Lesser General Public License v2.1
13.74k stars 7.43k forks source link

add waveshare_esp32_touch_amoled_241 #10342

Closed wurongmin closed 2 months ago

wurongmin commented 2 months ago

Component name: Waveshare_ESP32_TOUCH_AMOLED_241, for use in md files. I would like the board name to be Waveshare ESP32-Touch-AMOLED-2.41. This application will provide us with great publicity. The board has not been officially launched yet, but I can add the link once it is live. Our company's official website: https://www.waveshare.net/.

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

github-actions[bot] commented 2 months ago
Warnings
:warning: **Some issues found for the commit messages in this PR:** - the commit message `"feat(boards variants): add waveshare_esp32_touch_amoled_241"`: - *scope/component* should be lowercase without whitespace, allowed special characters are `_` `/` `.` `,` `*` `-` `.` *** **Please fix these commit messages** - here are some basic tips: - follow [Conventional Commits style](https://www.conventionalcommits.org/en/v1.0.0/) - correct format of commit message should be: `(): `, for example `fix(esp32): Fixed startup timeout issue` - allowed types are: `change,ci,docs,feat,fix,refactor,remove,revert,test` - sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter - avoid Jira references in commit messages (unavailable/irrelevant for our customers) `TIP:` Install pre-commit hooks and run this check when committing (uses the [Conventional Precommit Linter](https://github.com/espressif/conventional-precommit-linter)).
Messages
:book: You might consider squashing your 5 commits (simplifying branch history).

👋 Hello wurongmin, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by :no_entry_sign: dangerJS against 0ee91de1df56b5930fbdd1805f4bc498ce8a9b50

wurongmin commented 2 months ago

Why is there a red error? Does it indicate that manual review is needed?

me-no-dev commented 2 months ago

missing proper declaration for UART and SPI pins

me-no-dev commented 2 months ago

Also: https://github.com/espressif/arduino-esp32/actions/runs/10847091674/job/30102292599?pr=10342#step:3:16

wurongmin commented 2 months ago

I modified the UART, SPI, and the name suffix.