Closed me-no-dev closed 2 months ago
Warnings | |
---|---|
:warning: |
**Some issues found for the commit messages in this PR:**
- the commit message `"IDF release/v5.3 22858c37"`:
- *summary* looks empty
- *type/action* looks empty
***
**Please fix these commit messages** - here are some basic tips:
- follow [Conventional Commits style](https://www.conventionalcommits.org/en/v1.0.0/)
- correct format of commit message should be: ` |
:warning: | The **target branch** for this Pull Request **must be the default branch** of the project (`master`). If you would like to add this feature to a different branch, please state this in the PR description and we will consider it. |
π Hello me-no-dev, we appreciate your contribution to this project!
This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.
DangerJS is triggered with each push
event to a Pull Request and modify the contents of this comment.
Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (β οΈ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.
We do welcome contributions in the form of bug reports, feature requests and pull requests.
1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.
Generated by :no_entry_sign: dangerJS against dde4aa59c04980549de640a7188a8a9894ca8e21
β56 filesβ +β56βββ56 suitesβ +56βββ4m 15s :stopwatch: + 4m 15s β21 tests +β21βββ21 :white_check_mark: +β21ββ0 :zzz: Β±0ββ0 :x: Β±0β 135 runsβ +135ββ135 :white_check_mark: +135ββ0 :zzz: Β±0ββ0 :x: Β±0β
Results for commit dde4aa59.βΒ± Comparison against base commit 9398d52d.
:recycle: This comment has been updated with latest results.