search

espressif / arduino-esp32

Arduino core for the ESP32
GNU Lesser General Public License v2.1
13.74k stars 7.43k forks source link

Added Sparkfun ESP32-S3 Thing Plus board #10382

Closed Vigeant closed 1 month ago

Vigeant commented 2 months ago

Description of Change

Added support for Sparkfun ESP32-S3 Thing Plus based on sparkfun's example:

https://docs.sparkfun.com/SparkFun_Thing_Plus_ESP32-S3/arduino_example/#thing-plus-esp32-s3-github-repository

This guide uses the ESP32-S3 DEV Board and then redefines pins to adapt. I used the ESP32-S3 DEV Board as a base and made the changes in the boards.txt and the pins_arduino.h file to match the guide'options and the board's pin layout.

Tests scenarios

I have tested my Pull Request with sparkfun's examples on Arduino-esp32 core v3.1.0 with ESP32 and ESP32-S3 Board.

Related links

https://github.com/sparkfun/SparkFun_Thing_Plus_ESP32-S3 https://docs.sparkfun.com/SparkFun_Thing_Plus_ESP32-S3/arduino_example/#thing-plus-esp32-s3-github-repository

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

github-actions[bot] commented 2 months ago
Warnings
:warning: **Some issues found for the commit messages in this PR:** - the commit message `"Create pins_arduino.h"`: - *summary* looks empty - *type/action* looks empty - the commit message `"Update pins_arduino.h"`: - *summary* looks empty - *type/action* looks empty - the commit message `"added board Sparkfun ESP32-S3 Thing Plus"`: - *summary* looks empty - *type/action* looks empty - the commit message `"added sparkfun esp32-s3 thing plus"`: - *summary* looks empty - *type/action* looks empty - the commit message `"readded last line of hashes in boards.txt"`: - *summary* looks empty - *type/action* looks empty - the commit message `"removed unapplicable flash configurations the sparkfun esp32-s3 thing plus"`: - *summary* looks empty - *type/action* looks empty *** **Please fix these commit messages** - here are some basic tips: - follow [Conventional Commits style](https://www.conventionalcommits.org/en/v1.0.0/) - correct format of commit message should be: `(): `, for example `fix(esp32): Fixed startup timeout issue` - allowed types are: `change,ci,docs,feat,fix,refactor,remove,revert,test` - sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter - avoid Jira references in commit messages (unavailable/irrelevant for our customers) `TIP:` Install pre-commit hooks and run this check when committing (uses the [Conventional Precommit Linter](https://github.com/espressif/conventional-precommit-linter)).
:warning: Please consider squashing your 10 commits (simplifying branch history).

👋 Hello Vigeant, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by :no_entry_sign: dangerJS against 60838eb8222c685318ebe7af223acc83fc531d43

Vigeant commented 1 month ago

hey @P-R-O-C-H-Y how are you setup to use the latest master for your arduino IDE or PlatformIO setup?