espressif / arduino-esp32

Arduino core for the ESP32
GNU Lesser General Public License v2.1
13.73k stars 7.43k forks source link

Fix WPS example config initialization #10399

Closed me-no-dev closed 1 month ago

me-no-dev commented 1 month ago

It causes errors with newer C++ standarts

cc: @SuGlider

github-actions[bot] commented 1 month ago
Warnings
:warning: **Some issues found for the commit messages in this PR:** - the commit message `"fix(wps): adds memset to 0"`: - *summary* looks too short *** **Please fix these commit messages** - here are some basic tips: - follow [Conventional Commits style](https://www.conventionalcommits.org/en/v1.0.0/) - correct format of commit message should be: `(): `, for example `fix(esp32): Fixed startup timeout issue` - allowed types are: `change,ci,docs,feat,fix,refactor,remove,revert,test` - sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter - avoid Jira references in commit messages (unavailable/irrelevant for our customers) `TIP:` Install pre-commit hooks and run this check when committing (uses the [Conventional Precommit Linter](https://github.com/espressif/conventional-precommit-linter)).

πŸ‘‹ Hello me-no-dev, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by :no_entry_sign: dangerJS against 585022e93f5c3c84bd0ce4f1eedc1076ce206e4b

github-actions[bot] commented 1 month ago

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S3:green_heart: -1080:green_heart: -0.010.00000.000.00
ESP32S2:green_heart: -1000:green_heart: -0.010.00000.000.00
ESP32C3:green_heart: -740:green_heart: -0.010.00000.000.00
ESP32C6:green_heart: -740:green_heart: -0.010.00000.000.00
ESP32:green_heart: -1080:green_heart: -0.010.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
WiFi/examples/WPS:green_heart: -1080:green_heart: -1000:green_heart: -740:green_heart: -740:green_heart: -1080
github-actions[bot] commented 1 month ago

Test Results

 41 files   -β€Šβ€‡74   41 suites   -β€Š74   3m 12s :stopwatch: - 1h 33m 8s  19 tests  -β€Šβ€‡β€‡6   19 :white_check_mark:  -β€Šβ€‡β€‡5  0 :zzz: Β±0  0 :x:  -β€Š1  120 runsβ€Š  -β€Š153  120 :white_check_mark:  -β€Š152  0 :zzz: Β±0  0 :x:  -β€Š1 

Results for commit 585022e9. ± Comparison against base commit 84ddf0ad.

This pull request removes 6 tests. ``` performance.coremark.test_coremark ‑ test_coremark performance.fibonacci.test_fibonacci ‑ test_fibonacci performance.psramspeed.test_psramspeed ‑ test_psramspeed performance.ramspeed.test_ramspeed ‑ test_ramspeed performance.superpi.test_superpi ‑ test_superpi validation.periman.test_periman ‑ test_periman ```

:recycle: This comment has been updated with latest results.