Closed Bharat-Pi closed 1 month ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.
:white_check_mark: Bharat-Pi
:x: Neo G
Warnings | |
---|---|
:warning: |
**Some issues found for the commit messages in this PR:**
- the commit message `"Bharat Pi Arduino Libs for Lora and 4G Modules"`:
- *summary* looks empty
- *type/action* looks empty
- the commit message `"Bharat Pi Arduino libs"`:
- *summary* looks empty
- *type/action* looks empty
***
**Please fix these commit messages** - here are some basic tips:
- follow [Conventional Commits style](https://www.conventionalcommits.org/en/v1.0.0/)
- correct format of commit message should be: ` |
Messages | |
---|---|
:book: | You might consider squashing your 3 commits (simplifying branch history). |
👋 Hello Bharat-Pi, we appreciate your contribution to this project!
This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.
DangerJS is triggered with each push
event to a Pull Request and modify the contents of this comment.
Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.
We do welcome contributions in the form of bug reports, feature requests and pull requests.
1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.
Generated by :no_entry_sign: dangerJS against 8c796ccf697f6865f21803fb38a855eb646c7984
Checklist
All checklist is cleared
Description of Change
This Pull Request add support to three new hardware on the market using ESP32 modules, Bharat Pi Node Wifi , Bharat Pi A7672s 4G and Bharat Pi LoRa modules. Links to the hardware is provided below
Bharat Pi Node Wifi https://bharatpi.net/product/bharat-pi-node-wifi/
Bharat Pi A7672s 4G Board https://bharatpi.net/product/bharat-pi-4g-lte-module-with-esp32-simcom-a7672-with-gps/
Bharat Pi LoRa boards with Indian Frequency https://bharatpi.net/product/bharat-pi-lora-module-with-esp32-lora868mhz-transreceiver-with-esp32-arduino-compatible/
These boards are used by Students, Tinkerers across 100s of different colleges and universities and we are connected with the Espressif to launch these boards.
Tests scenarios
We have tested these changes on a Bharat Pi boards using the Arduino IDE and the ESP32 core with 4MB, 8MB and 16MB flash versions of ESP32. We have verified that the defined pins correspond to the correct hardware pins on the board. We tested the samples codes and libraries of our code and example codes. You can see our test codes in this page https://github.com/Bharat-Pi/iot-projects
Related links
This is a support package for new boards. https://github.com/Bharat-Pi/iot-projects https://bharatpi.net/product/bharat-pi-node-wifi/ https://bharatpi.net/product/bharat-pi-4g-lte-module-with-esp32-simcom-a7672-with-gps/ https://bharatpi.net/product/bharat-pi-lora-module-with-esp32-lora868mhz-transreceiver-with-esp32-arduino-compatible/