espressif / arduino-esp32

Arduino core for the ESP32
GNU Lesser General Public License v2.1
13.75k stars 7.44k forks source link

Update FreeRTOS Symbols in OThreadCLI #10412

Closed SuGlider closed 1 month ago

SuGlider commented 1 month ago

Description of Change

TARGET: 3.0.x and 3.1.x

Fixes FreeRTOS types. This affects certain ways of building applications using IDF Components.

Tests scenarios

CI only.

Related links

github-actions[bot] commented 1 month ago
Warnings
:warning: **Some issues found for the commit messages in this PR:** - the commit message `"Update OThreadCLI.cpp"`: - *summary* looks empty - *type/action* looks empty *** **Please fix these commit messages** - here are some basic tips: - follow [Conventional Commits style](https://www.conventionalcommits.org/en/v1.0.0/) - correct format of commit message should be: `(): `, for example `fix(esp32): Fixed startup timeout issue` - allowed types are: `change,ci,docs,feat,fix,refactor,remove,revert,test` - sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter - avoid Jira references in commit messages (unavailable/irrelevant for our customers) `TIP:` Install pre-commit hooks and run this check when committing (uses the [Conventional Precommit Linter](https://github.com/espressif/conventional-precommit-linter)).
Messages
:book: You might consider squashing your 3 commits (simplifying branch history).

👋 Hello SuGlider, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by :no_entry_sign: dangerJS against 78a3ca57eadeff5cf604f5d902be8c9edce47a3a

github-actions[bot] commented 1 month ago

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C6ESP32H2
ExampleFLASHRAMFLASHRAM
OpenThread/examples/COAP/coap_lamp0000
OpenThread/examples/COAP/coap_switch0000
OpenThread/examples/SimpleCLI0000
OpenThread/examples/SimpleNode0000
OpenThread/examples/SimpleThreadNetwork/ExtendedRouterNode0000
OpenThread/examples/SimpleThreadNetwork/LeaderNode0000
OpenThread/examples/SimpleThreadNetwork/RouterNode0000
OpenThread/examples/ThreadScan0000
OpenThread/examples/onReceive0000
github-actions[bot] commented 1 month ago

Test Results

 41 files   41 suites   3m 12s :stopwatch:  19 tests  19 :white_check_mark: 0 :zzz: 0 :x: 120 runs  120 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 78a3ca57.

:recycle: This comment has been updated with latest results.