Closed Y1hsiaochunnn closed 1 month ago
Warnings | |
---|---|
:warning: |
**Some issues found for the commit messages in this PR:**
- the commit message `"Added variant for Waveshare ESP32-S3-Touch-AMOLED-1.8"`:
- probably contains Jira ticket reference (`AMOLED-1`). Please remove Jira tickets from commit messages.
- *summary* looks empty
- *type/action* looks empty
***
**Please fix these commit messages** - here are some basic tips:
- follow [Conventional Commits style](https://www.conventionalcommits.org/en/v1.0.0/)
- correct format of commit message should be: ` |
👋 Hello Y1hsiaochunnn, we appreciate your contribution to this project!
This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.
DangerJS is triggered with each push
event to a Pull Request and modify the contents of this comment.
Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.
We do welcome contributions in the form of bug reports, feature requests and pull requests.
1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.
Generated by :no_entry_sign: dangerJS against cf401a88d1a3a118af3f43d4e274f03a1b5a0451
Hi, @P-R-O-C-H-Y . I would like to know when arduino-esp32 v3.0.6 will be released, I am working on the product wiki and as mentioned before I can specify this 3rd party board with v3.0.6
Hi, @P-R-O-C-H-Y . I would like to know when arduino-esp32 v3.0.6 will be released, I am working on the product wiki and as mentioned before I can specify this 3rd party board with v3.0.6
Hi @Y1hsiaochunnn, the v3.0.6 should be released this week :)
Description of Change
Adding variant for Waveshare ESP32-S3-Touch-AMOLED-1.8 board containing MCU, AMOLED, RTC, and IMU.
Tests scenarios
Untested,Pre-publisher board definition
Related links
processed USB VID PR: espressif/usb-pids/pull/194