espressif / arduino-esp32

Arduino core for the ESP32
GNU Lesser General Public License v2.1
13.73k stars 7.43k forks source link

fix(testing): Checkout proper branch for Wokwi tests and small QoL improvements #10435

Closed lucasssvaz closed 1 month ago

lucasssvaz commented 1 month ago

Description of Change

Testing

Local and CI in fork

github-actions[bot] commented 1 month ago
Warnings
:warning: Please consider squashing your 7 commits (simplifying branch history).

👋 Hello lucasssvaz, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by :no_entry_sign: dangerJS against 10afaf08ed1fd47efeb0c3722d25a466d304c896

github-actions[bot] commented 1 month ago

Test Results

 56 files   56 suites   4m 8s :stopwatch:  21 tests  21 :white_check_mark: 0 :zzz: 0 :x: 134 runs  134 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 10afaf08.

:recycle: This comment has been updated with latest results.

me-no-dev commented 1 month ago

This will cause merge issues into 3.1. We can merge it when you are online @lucasssvaz