Closed maxpromer closed 1 month ago
Warnings | |
---|---|
:warning: |
**Some issues found for the commit messages in this PR:**
- the commit message `"Add IOXESP32-C6 and ATD3.5-S3 board"`:
- *summary* looks empty
- *type/action* looks empty
***
**Please fix these commit messages** - here are some basic tips:
- follow [Conventional Commits style](https://www.conventionalcommits.org/en/v1.0.0/)
- correct format of commit message should be: ` |
👋 Hello maxpromer, we appreciate your contribution to this project!
This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.
DangerJS is triggered with each push
event to a Pull Request and modify the contents of this comment.
Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.
We do welcome contributions in the form of bug reports, feature requests and pull requests.
1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.
Generated by :no_entry_sign: dangerJS against 43db825a9f681b4e69eb7d6be5cf626b8b940209
Description of Change
This Pull Request add support to three new hardware on the market using ESP32-C6 and ESP32-S3 modules, IOXESP32-C6, ATD3.5-S3. Links to the hardware is provided below
IOXESP32-C6 https://www.artronshop.co.th/product/647/ioxesp32-c6-%E0%B8%9A%E0%B8%AD%E0%B8%A3%E0%B9%8C%E0%B8%94-esp32-c6-%E0%B9%80%E0%B8%8A%E0%B8%B7%E0%B9%88%E0%B8%AD%E0%B8%A1%E0%B8%95%E0%B9%88%E0%B8%AD-wifi-6-bluetooth-5-thread-zigbee
ATD3.5-S3 https://www.artronshop.co.th/product/567/atd3-5-s3-%E0%B8%9A%E0%B8%AD%E0%B8%A3%E0%B9%8C%E0%B8%94-esp32-s3-%E0%B8%9E%E0%B8%A3%E0%B9%89%E0%B8%AD%E0%B8%A1%E0%B8%88%E0%B8%AD-3-5-%E0%B8%99%E0%B8%B4%E0%B9%89%E0%B8%A7-%E0%B8%97%E0%B8%B1%E0%B8%8A-capacitive
These boards are used by Students, Maker and Engineer in Thailand
Tests scenarios
I have tested my Pull Request on Arduino-esp32 core v3.0.5 with real hardware
Related links
-