github-actions[bot]
commented
1 month ago | Warnings | |
|---|---|
| :warning: |
**Some issues found for the commit messages in this PR:**
- the commit message `"ci(FQBN): Use QIO as default as DIO can be used on demand now"`:
- *scope/component* should be lowercase without whitespace, allowed special characters are `_` `/` `.` `,` `*` `-` `.`
***
**Please fix these commit messages** - here are some basic tips:
- follow [Conventional Commits style](https://www.conventionalcommits.org/en/v1.0.0/)
- correct format of commit message should be: ` |
| Messages | |
|---|---|
| :book: | You might consider squashing your 5 commits (simplifying branch history). |
👋 Hello lucasssvaz, we appreciate your contribution to this project!
Click to see more instructions ...
This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.
DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.
Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.
Review and merge process you can expect ...
We do welcome contributions in the form of bug reports, feature requests and pull requests.
1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.
Generated by :no_entry_sign: dangerJS against 4eab83b07d07ea77458e80b1a074decb34fdde3e
Description of Change
As we can easily change the flash mode for some sketch to DIO, lets switch the default back to QIO so we match the IDE default.
Also add the
requires_anyfield to the JSON so we can match requirements in a OR configuration. This will be useful for sketches that require one option or the other, for example the sketches that require WiFi connectivity needs eitherCONFIG_SOC_WIFI_SUPPORTED=yorCONFIG_ESP_WIFI_REMOTE_ENABLED=y.Also add some QoL improvements.
Tests scenarios
CI