espressif / arduino-esp32

Arduino core for the ESP32
GNU Lesser General Public License v2.1
13.71k stars 7.43k forks source link

Add RMII Ethernet support for ESP32-P4 #10479

Closed me-no-dev closed 1 month ago

me-no-dev commented 1 month ago

Also adds default config to the P4 pins_arduino.h

github-actions[bot] commented 1 month ago
Warnings
:warning: The Pull Request description looks very brief, please check if more details can be added.
:warning: The **target branch** for this Pull Request **must be the default branch** of the project (`master`). If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.
Messages
:book: You might consider squashing your 4 commits (simplifying branch history).

πŸ‘‹ Hello me-no-dev, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (πŸ“–) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by :no_entry_sign: dangerJS against 9363ce883888ade63044dc55323bfe139c4dc9f1

github-actions[bot] commented 1 month ago

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32P4000.000.00000.000.00
ESP32S30:bangbang: +17K0.00:bangbang: +2.740:bangbang: +2K0.00:bangbang: +8.27
ESP32S20:bangbang: +14K0.00:bangbang: +2.340:bangbang: +2K0.00:bangbang: +8.80
ESP32C30:bangbang: +20K0.00:bangbang: +3.330:bangbang: +2K0.00:bangbang: +10.32
ESP32C60:bangbang: +35K0.00:bangbang: +3.950:bangbang: +22K0.00:bangbang: +127.95
ESP32H20:bangbang: +11K0.00:bangbang: +2.120:bangbang: +22K0.00:bangbang: +126.07
ESP320:bangbang: +14K0.00:bangbang: +2.160:warning: +13520.00:bangbang: +3.19
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
Ethernet/examples/ETH_TLK110------------:bangbang: +11K:warning: +800
Ethernet/examples/ETH_W5500_Arduino_SPI--:bangbang: +15K:warning: +1940:bangbang: +12K:warning: +1668:bangbang: +17K:warning: +1744:bangbang: +19K:bangbang: +22K:bangbang: +11K:bangbang: +22K:bangbang: +8K:warning: +736
Ethernet/examples/ETH_W5500_IDF_SPI--:bangbang: +14K:warning: +1908:bangbang: +11K:warning: +1620:bangbang: +17K:warning: +1744:bangbang: +19K:bangbang: +22K:bangbang: +11K:bangbang: +22K:bangbang: +7K:warning: +672
Ethernet/examples/ETH_WIFI_BRIDGE--:bangbang: +17K:bangbang: +2K:bangbang: +14K:bangbang: +2K:bangbang: +20K:bangbang: +2K:bangbang: +35K:bangbang: +4K--:bangbang: +14K:warning: +1352
Ethernet/examples/ETH_LAN8720------------:bangbang: +11K:warning: +800
github-actions[bot] commented 1 month ago

Test Results

 56 files  Β±0   56 suites  Β±0   4m 17s :stopwatch: -1s  21 tests Β±0   21 :white_check_mark: Β±0  0 :zzz: Β±0  0 :x: Β±0  135 runsβ€Š Β±0  135 :white_check_mark: Β±0  0 :zzz: Β±0  0 :x: Β±0 

Results for commit 9363ce88. ± Comparison against base commit 612fc4c4.

:recycle: This comment has been updated with latest results.