Closed me-no-dev closed 1 month ago
Warnings | |
---|---|
:warning: | The Pull Request description looks very brief, please check if more details can be added. |
:warning: | The **target branch** for this Pull Request **must be the default branch** of the project (`master`). If you would like to add this feature to a different branch, please state this in the PR description and we will consider it. |
Messages | |
---|---|
:book: | You might consider squashing your 4 commits (simplifying branch history). |
π Hello me-no-dev, we appreciate your contribution to this project!
This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.
DangerJS is triggered with each push
event to a Pull Request and modify the contents of this comment.
Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (β οΈ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (π) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.
We do welcome contributions in the form of bug reports, feature requests and pull requests.
1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.
Generated by :no_entry_sign: dangerJS against 9363ce883888ade63044dc55323bfe139c4dc9f1
The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Memory | FLASH [bytes] | FLASH [%] | RAM [bytes] | RAM [%] | ||||
---|---|---|---|---|---|---|---|---|
Target | DEC | INC | DEC | INC | DEC | INC | DEC | INC |
ESP32P4 | 0 | 0 | 0.00 | 0.00 | 0 | 0 | 0.00 | 0.00 |
ESP32S3 | 0 | :bangbang: +17K | 0.00 | :bangbang: +2.74 | 0 | :bangbang: +2K | 0.00 | :bangbang: +8.27 |
ESP32S2 | 0 | :bangbang: +14K | 0.00 | :bangbang: +2.34 | 0 | :bangbang: +2K | 0.00 | :bangbang: +8.80 |
ESP32C3 | 0 | :bangbang: +20K | 0.00 | :bangbang: +3.33 | 0 | :bangbang: +2K | 0.00 | :bangbang: +10.32 |
ESP32C6 | 0 | :bangbang: +35K | 0.00 | :bangbang: +3.95 | 0 | :bangbang: +22K | 0.00 | :bangbang: +127.95 |
ESP32H2 | 0 | :bangbang: +11K | 0.00 | :bangbang: +2.12 | 0 | :bangbang: +22K | 0.00 | :bangbang: +126.07 |
ESP32 | 0 | :bangbang: +14K | 0.00 | :bangbang: +2.16 | 0 | :warning: +1352 | 0.00 | :bangbang: +3.19 |
Target | ESP32P4 | ESP32S3 | ESP32S2 | ESP32C3 | ESP32C6 | ESP32H2 | ESP32 | |||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Example | FLASH | RAM | FLASH | RAM | FLASH | RAM | FLASH | RAM | FLASH | RAM | FLASH | RAM | FLASH | RAM |
Ethernet/examples/ETH_TLK110 | - | - | - | - | - | - | - | - | - | - | - | - | :bangbang: +11K | :warning: +800 |
Ethernet/examples/ETH_W5500_Arduino_SPI | - | - | :bangbang: +15K | :warning: +1940 | :bangbang: +12K | :warning: +1668 | :bangbang: +17K | :warning: +1744 | :bangbang: +19K | :bangbang: +22K | :bangbang: +11K | :bangbang: +22K | :bangbang: +8K | :warning: +736 |
Ethernet/examples/ETH_W5500_IDF_SPI | - | - | :bangbang: +14K | :warning: +1908 | :bangbang: +11K | :warning: +1620 | :bangbang: +17K | :warning: +1744 | :bangbang: +19K | :bangbang: +22K | :bangbang: +11K | :bangbang: +22K | :bangbang: +7K | :warning: +672 |
Ethernet/examples/ETH_WIFI_BRIDGE | - | - | :bangbang: +17K | :bangbang: +2K | :bangbang: +14K | :bangbang: +2K | :bangbang: +20K | :bangbang: +2K | :bangbang: +35K | :bangbang: +4K | - | - | :bangbang: +14K | :warning: +1352 |
Ethernet/examples/ETH_LAN8720 | - | - | - | - | - | - | - | - | - | - | - | - | :bangbang: +11K | :warning: +800 |
β56 filesβ Β±0βββ56 suitesβ Β±0βββ4m 17s :stopwatch: -1s β21 tests Β±0βββ21 :white_check_mark: Β±0ββ0 :zzz: Β±0ββ0 :x: Β±0β 135 runsβ Β±0ββ135 :white_check_mark: Β±0ββ0 :zzz: Β±0ββ0 :x: Β±0β
Results for commit 9363ce88.βΒ± Comparison against base commit 612fc4c4.
:recycle: This comment has been updated with latest results.
Also adds default config to the P4 pins_arduino.h