Closed lboue closed 1 month ago
Messages | |
---|---|
:book: | π Good Job! All checks are passing! |
π Hello lboue, we appreciate your contribution to this project!
This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.
DangerJS is triggered with each push
event to a Pull Request and modify the contents of this comment.
Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.
We do welcome contributions in the form of bug reports, feature requests and pull requests.
1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.
Generated by :no_entry_sign: dangerJS against d556fab67558a111b2edc5ec63b724696d2405d6
The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Memory | FLASH [bytes] | FLASH [%] | RAM [bytes] | RAM [%] | ||||
---|---|---|---|---|---|---|---|---|
Target | DEC | INC | DEC | INC | DEC | INC | DEC | INC |
ESP32C6 | 0 | 0 | 0.00 | 0.00 | 0 | 0 | 0.00 | 0.00 |
ESP32H2 | 0 | 0 | 0.00 | 0.00 | 0 | 0 | 0.00 | 0.00 |
Target | ESP32C6 | ESP32H2 | ||
---|---|---|---|---|
Example | FLASH | RAM | FLASH | RAM |
Zigbee/examples/Zigbee_Color_Dimmable_Light | 0 | 0 | 0 | 0 |
Zigbee/examples/Zigbee_Color_Dimmer_Switch | 0 | 0 | 0 | 0 |
Zigbee/examples/Zigbee_On_Off_Light | 0 | 0 | 0 | 0 |
Zigbee/examples/Zigbee_Temperature_Sensor | 0 | 0 | 0 | 0 |
Zigbee/examples/Zigbee_Thermostat | 0 | 0 | 0 | 0 |
β56 filesβββ56 suitesβββ4m 9s β±οΈ β21 testsββ21 β β0 π€β0 β 134 runsββ134 β β0 π€β0 β
Results for commit d556fab6.
:recycle: This comment has been updated with latest results.
@P-R-O-C-H-Y PTAL
Description of Change
Configure
BUTTON_PIN
/SWITCH_PIN
as an input and enable the internal pull-up resistor. I am facing a factory reset loop using a Waveshare ESP32-H2-DEV-KIT-N4 board witout enabling pull-up.Tests scenarios
I tested this with : Waveshare ESP32-H2-DEV-KIT-N4 board ESP32-C6-WROOM-1 board
Related links
Please provide links to related issue, PRs etc.