feat(boards): add Waveshare ESP32-S3-Touch-AMOLED boards

wurongmin commented 4 weeks ago

1.I added four ESP32S3 products: ESP32-S3-Touch-AMOLED-1.43, ESP32-S3-Touch-AMOLED-1.64, ESP32-S3-Touch-AMOLED-1.91, and ESP32-S3-Touch-LCD-1.9. 2.Among them, the ESP32-S3-Touch-AMOLED-1.91 is already available online. The link is as follows: https://www.waveshare.net/shop/ESP32-S3-Touch-AMOLED-1.91.htm. The others will be available soon. 3.I believe many people will love our products for the ability to customize their own board names.This will further enhance our promotion.

github-actions[bot] commented 4 weeks ago

	Warnings
:warning:	Some issues found for the commit messages in this PR: - the commit message `"Update boards.txt"`: - summary looks empty - type/action looks empty * Please fix these commit messages** - here are some basic tips: - follow [Conventional Commits style](https://www.conventionalcommits.org/en/v1.0.0/) - correct format of commit message should be: `(): `, for example `fix(esp32): Fixed startup timeout issue` - allowed types are: `change,ci,docs,feat,fix,refactor,remove,revert,test` - sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter - avoid Jira references in commit messages (unavailable/irrelevant for our customers) `TIP:` Install pre-commit hooks and run this check when committing (uses the [Conventional Precommit Linter](https://github.com/espressif/conventional-precommit-linter)).

Warnings

:warning:

**Some issues found for the commit messages in this PR:** - the commit message `"Update boards.txt"`: - *summary* looks empty - *type/action* looks empty *** **Please fix these commit messages** - here are some basic tips: - follow [Conventional Commits style](https://www.conventionalcommits.org/en/v1.0.0/) - correct format of commit message should be: `():

`, for example `fix(esp32): Fixed startup timeout issue` - allowed types are: `change,ci,docs,feat,fix,refactor,remove,revert,test` - sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter - avoid Jira references in commit messages (unavailable/irrelevant for our customers) `TIP:` Install pre-commit hooks and run this check when committing (uses the [Conventional Precommit Linter](https://github.com/espressif/conventional-precommit-linter)).

	Messages
:book:	You might consider squashing your 5 commits (simplifying branch history).
:book:	This PR seems to be quite large (total lines of code: 93304), you might consider splitting it into smaller PRs

👋 Hello wurongmin, we appreciate your contribution to this project!

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by :no_entry_sign: dangerJS against efee06af2b299742757ad92eb4b8b2a561e5189a

wurongmin commented 4 weeks ago

Why can't the test board pass

me-no-dev commented 4 weeks ago

All 4 boards are the same. I suggest you combine them into 1 "ESP32-S3-Touch-AMOLED". Having multiple boards with the same VID and PID is also not a great idea. Please also look into why CI is failing for your boards

me-no-dev commented 4 weeks ago

You have not defined I2C pins: https://github.com/espressif/arduino-esp32/actions/runs/11515946102/job/32057623865?pr=10520#step:5:294

wurongmin commented 4 weeks ago

I'm sorry, they're not the same, PID's not the same

me-no-dev commented 4 weeks ago

@wurongmin why did you change the updated title?

wurongmin commented 4 weeks ago

Because I thought this description would be better, but of course I think it's better to use your previous description. If this description is necessary, I apologize for my behavior.