search

espressif / arduino-esp32

Arduino core for the ESP32
GNU Lesser General Public License v2.1
13.73k stars 7.43k forks source link

feat(Example): Remove o call to a no existing method from Serial example #10553

Closed thalesdemond closed 3 weeks ago

thalesdemond commented 3 weeks ago

Description of Change

On the exemple Serial_ALL_CPU_Freqs there were a call to a method that does not exit o the library, Serial.updateBaudRate(115200) .

Tests scenarios

The used hardware was a ESP32-S3-BOX I was only trying to run the exemple code.

CLAassistant commented 3 weeks ago

CLA assistant check
All committers have signed the CLA.

github-actions[bot] commented 3 weeks ago
Warnings
:warning: **Some issues found for the commit messages in this PR:** - the commit message `"Remove o call to a no exixting method"`: - *summary* looks empty - *type/action* looks empty *** **Please fix these commit messages** - here are some basic tips: - follow [Conventional Commits style](https://www.conventionalcommits.org/en/v1.0.0/) - correct format of commit message should be: `(): `, for example `fix(esp32): Fixed startup timeout issue` - allowed types are: `change,ci,docs,feat,fix,refactor,remove,revert,test` - sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter - avoid Jira references in commit messages (unavailable/irrelevant for our customers) `TIP:` Install pre-commit hooks and run this check when committing (uses the [Conventional Precommit Linter](https://github.com/espressif/conventional-precommit-linter)).

👋 Hello thalesdemond, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by :no_entry_sign: dangerJS against bd41859d49d442f08bce7a9ad69fc85b7358881f

lucasssvaz commented 3 weeks ago

@thalesdemond The function does indeed exist. You can find it here:

https://github.com/espressif/arduino-esp32/blob/release/v3.0.x/cores/esp32/HardwareSerial.cpp#L392