Closed lucasssvaz closed 2 weeks ago
Messages | |
---|---|
:book: | π Good Job! All checks are passing! |
π Hello lucasssvaz, we appreciate your contribution to this project!
This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.
DangerJS is triggered with each push
event to a Pull Request and modify the contents of this comment.
Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.
We do welcome contributions in the form of bug reports, feature requests and pull requests.
1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.
Generated by :no_entry_sign: dangerJS against 02bec1a70fb974883bc200906df86fc2e6de8d65
β56 filesβββ56 suitesβββ4m 22s β±οΈ β21 testsββ21 β β0 π€β0 β 134 runsββ134 β β0 π€β0 β
Results for commit c7c4f680.
:recycle: This comment has been updated with latest results.
Description of Change
Using the
-k
flag in the pytest command might run more than the selected test. For example using-k test_psram
will run bothtest_psram
andtest_psramspeed
. To fix this we can directly pass the python file for the test.Also, to help with testing, added a
-d
flag to the compilation process. This will be useful to compile tests with debug logs enabled. For example:./.github/scripts/tests_build.sh -s uart -t esp32 -d verbose
Tests scenarios
Tested locally