Closed SuGlider closed 1 week ago
Warnings | |
---|---|
:warning: | Please consider squashing your 6 commits (simplifying branch history). |
Messages | |
---|---|
:book: | This PR seems to be quite large (total lines of code: 1983), you might consider splitting it into smaller PRs |
π Hello SuGlider, we appreciate your contribution to this project!
This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.
DangerJS is triggered with each push
event to a Pull Request and modify the contents of this comment.
Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (β οΈ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (π) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.
We do welcome contributions in the form of bug reports, feature requests and pull requests.
1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.
Generated by :no_entry_sign: dangerJS against b5b5ebd3e04cd4da9f1998aa36e2c51dacfbf165
β56 filesβββ56 suitesβββ4m 15s β±οΈ β21 testsββ21 β β0 π€β0 β 134 runsββ134 β β0 π€β0 β
Results for commit b5b5ebd3.
:recycle: This comment has been updated with latest results.
Description of Change
This PR fixes a problem related to sending just modifier key pressing/releasing (SHIFT/CTRL/ALT). It also adds the upstream Keyboard Layouts to the library. Additionally it adds the Brazilian ABNT2 Keyboard Layout.
Tests scenarios
Tested with ESP32-S3 using a Keyboard Test website. Configuration: CDC on Boot: Disabled || USB Mode: OTG(TinyUSB)
The new Keyboard Layout needs a compatible Keyboard of the selected location. Example:
Related links
Fixes #10368