espressif / arduino-esp32

Arduino core for the ESP32
GNU Lesser General Public License v2.1
13.71k stars 7.43k forks source link

fix(Zigbee): Add missing direction to report commands #10623

Closed P-R-O-C-H-Y closed 2 days ago

P-R-O-C-H-Y commented 3 days ago

Description of Change

This PR fixes Zigbee reporting (temp, humidity, battery level) as there was a direction missing in the command. Needs backport to 3.0.X.

Tests scenarios

Tested locally.

Related links

Closes #10612 Related to #10601

github-actions[bot] commented 3 days ago
Warnings
:warning: **Some issues found for the commit messages in this PR:** - the commit message `"fix(Zigbee): Add missing direction to report commands"`: - *scope/component* should be lowercase without whitespace, allowed special characters are `_` `/` `.` `,` `*` `-` `.` *** **Please fix these commit messages** - here are some basic tips: - follow [Conventional Commits style](https://www.conventionalcommits.org/en/v1.0.0/) - correct format of commit message should be: `(): `, for example `fix(esp32): Fixed startup timeout issue` - allowed types are: `change,ci,docs,feat,fix,refactor,remove,revert,test` - sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter - avoid Jira references in commit messages (unavailable/irrelevant for our customers) `TIP:` Install pre-commit hooks and run this check when committing (uses the [Conventional Precommit Linter](https://github.com/espressif/conventional-precommit-linter)).
:warning: The **target branch** for this Pull Request **must be the default branch** of the project (`master`). If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.
Messages
:book: You might consider squashing your 3 commits (simplifying branch history).

πŸ‘‹ Hello P-R-O-C-H-Y, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (πŸ“–) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by :no_entry_sign: dangerJS against f5ebbd1e554631f66d53ca796647ef26198cdd6e

github-actions[bot] commented 3 days ago

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C6:green_heart: -227:bangbang: +13K:green_heart: -0.05:bangbang: +2.700:warning: +16640.00:bangbang: +5.60
ESP32H2:green_heart: -4K:bangbang: +9K:green_heart: -0.69:bangbang: +1.830:warning: +15720.00:bangbang: +5.42
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C6ESP32H2
ExampleFLASHRAMFLASHRAM
Zigbee/examples/Zigbee_Color_Dimmable_Light:bangbang: +2K:warning: +1664:green_heart: -457:warning: +1572
Zigbee/examples/Zigbee_Color_Dimmer_Switch:bangbang: +9K:warning: +936:bangbang: +6K:warning: +844
Zigbee/examples/Zigbee_On_Off_Light:bangbang: +3K:warning: +1664:green_heart: -353:warning: +1572
Zigbee/examples/Zigbee_On_Off_Switch:bangbang: +9K:warning: +920:bangbang: +6K:warning: +844
Zigbee/examples/Zigbee_Scan_Networks:bangbang: +13K:warning: +1236:bangbang: +9K:warning: +1112
Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy:green_heart: -227:warning: +964:green_heart: -4K:warning: +832
Zigbee/examples/Zigbee_Temperature_Sensor:bangbang: +11K:warning: +944:bangbang: +7K:warning: +836
Zigbee/examples/Zigbee_Thermostat:bangbang: +11K:warning: +608:bangbang: +8K:warning: +540
github-actions[bot] commented 3 days ago

Test Results

 62 files   62 suites   7m 45s ⏱️  22 tests  21 βœ…β€ƒ0 πŸ’€β€ƒ1 ❌ 144 runsβ€Šβ€ƒ143 βœ…β€ƒ0 πŸ’€β€ƒ1 ❌

For more details on these failures, see this check.

Results for commit f5ebbd1e.

:recycle: This comment has been updated with latest results.